Date: Mon, 12 Jan 2009 10:03:07 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Mandeep Singh Baines <msb@google.com>
Cc: linux-kernel@vger.kernel.org, rientjes@google.com, mbligh@google.com,
       thockin@google.com
Subject: Re: [PATCH v2] softlockup: decouple hung tasks check from
	softlockup detection
Message-ID: <20090112090307.GC26750@elte.hu>
References: <20090112065213.GA19795@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090112065213.GA19795@google.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1222
Lines: 30


* Mandeep Singh Baines <msb@google.com> wrote:

> Decoupling allows:
> 
> * hung tasks check to happen at very low priority
> * hung tasks check and softlockup to be enabled/disabled independently
>   at compile and/or run-time
> * individual panic settings to be enabled disabled independently
>   at compile and/or run-time
> * softlockup threshold to be reduced without increasing hung tasks
>   poll frequency (hung task check is expensive relative to softlock watchdog)
> * hung task check to be zero over-head when disabled at run-time
> ---
>  include/linux/sched.h |   14 +++++--
>  kernel/Makefile       |    1 +
>  kernel/softlockup.c   |  102 -------------------------------------------------
>  kernel/sysctl.c       |   15 +++++++-
>  lib/Kconfig.debug     |   38 ++++++++++++++++++
>  5 files changed, 63 insertions(+), 107 deletions(-)

Looks good in principle, but i suspect your patch submission should 
include the new kernel/hung_task.c file too ;-)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/