Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755138AbZALLfs (ORCPT ); Mon, 12 Jan 2009 06:35:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751082AbZALLfh (ORCPT ); Mon, 12 Jan 2009 06:35:37 -0500 Received: from jurassic.park.msu.ru ([195.208.223.243]:39854 "EHLO jurassic.park.msu.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751023AbZALLfg (ORCPT ); Mon, 12 Jan 2009 06:35:36 -0500 Date: Mon, 12 Jan 2009 14:35:44 +0300 From: Ivan Kokshaysky To: Johannes Weiner Cc: Nick Piggin , Andrew Morton , Richard Henderson , linux-kernel@vger.kernel.org Subject: Re: [PATCH] alpha: fix vmalloc breakage Message-ID: <20090112113544.GA4609@jurassic.park.msu.ru> References: <20090107230144.GA30170@jurassic.park.msu.ru> <20090111230430.GA17873@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090111230430.GA17873@cmpxchg.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 492 Lines: 15 On Mon, Jan 12, 2009 at 12:04:30AM +0100, Johannes Weiner wrote: > > + va = alloc_bootmem(sizeof(struct vmap_area)); > > + if (!va) > > + break; > > You don't need this check, alloc_bootmem() panics when it fails. Ah, indeed. Thanks. Ivan. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/