Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755153AbZALLjm (ORCPT ); Mon, 12 Jan 2009 06:39:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752091AbZALLje (ORCPT ); Mon, 12 Jan 2009 06:39:34 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:44041 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750842AbZALLjd (ORCPT ); Mon, 12 Jan 2009 06:39:33 -0500 Date: Mon, 12 Jan 2009 12:39:23 +0100 From: Ingo Molnar To: Jaswinder Singh Rajput Cc: Jiri Kosina , Jeremy Fitzhardinge , linux-kernel@vger.kernel.org, Jaswinder Singh Rajput , "H. Peter Anvin" , Thomas Gleixner Subject: Re: build breakage -- paravirt_{alloc,free}_ldt Message-ID: <20090112113923.GC21051@elte.hu> References: <20090112105202.GF10405@elte.hu> <3f9a31f40901120319l4fac84e4me193fb314bdbbcaa@mail.gmail.com> <20090112112458.GA19388@elte.hu> <3f9a31f40901120336p5ef464e8ta4a9eac2b397b5f6@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f9a31f40901120336p5ef464e8ta4a9eac2b397b5f6@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: 1.0 X-ELTE-SpamLevel: s X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=1.0 required=5.9 tests=BAYES_50 autolearn=no SpamAssassin version=3.2.3 1.0 BAYES_50 BODY: Bayesian spam probability is 40 to 60% [score: 0.4478] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2111 Lines: 54 * Jaswinder Singh Rajput wrote: > On Mon, Jan 12, 2009 at 4:54 PM, Ingo Molnar wrote: > > > > * Jaswinder Singh Rajput wrote: > > > >> On Mon, Jan 12, 2009 at 4:42 PM, Jiri Kosina wrote: > >> > On Mon, 12 Jan 2009, Ingo Molnar wrote: > >> > > >> >> > with Linus' tree (ae04d14015) doesn't build for me with > >> >> > > >> >> > arch/x86/kernel/ldt.c: In function 'alloc_ldt': > >> >> > arch/x86/kernel/ldt.c:55: error: implicit declaration of function 'paravirt_alloc_ldt' > >> >> > arch/x86/kernel/ldt.c:79: error: implicit declaration of function 'paravirt_free_ldt' > >> >> > > >> >> > Config on http://www.jikos.cz/jikos/junk/.config > >> >> > >> >> hm, it builds fine here with your config. Did .28 build fine for you? The > >> >> only change to this file since .28 has been Jaswinder's "423a540: x86: > >> >> ldt.c fix style problems". > >> > > >> > Puzzled. On one system, I still get this build error even after make > >> > mrpoper (I use this machine to build kernel routinely, so it certainly > >> > didn't happen a few days ago). > >> > > >> > But I just tried on different system, and there is builds flawlessly. It's > >> > gcc 4.3.1 vs 4.3.2. I will check a little bit more. > >> > > >> > >> I am using gcc 4.3.2 > >> > >> Please check 'git diff' if by mistake some thing is gone wrong or check > >> 'git log' > > > > That wont show working tree corruption. > > > > It works for me for my old 166 MHz pentium machine after crashing the > system, 'git diff' tells which files are broken ;-) That's cool from Git :-) Thinking about it, it might not necessarily detect all corruption patterns though: git diff is sys_lstat() driven - so if a corruption corrupts a single block on the filesystem (in a working tree file), git diff wont know about that. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/