Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S291888AbSBNUud>; Thu, 14 Feb 2002 15:50:33 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S291851AbSBNUuU>; Thu, 14 Feb 2002 15:50:20 -0500
Received: from smtp3.vol.cz ([195.250.128.83]:35344 "EHLO smtp3.vol.cz")
	by vger.kernel.org with ESMTP id <S291878AbSBNUuC>;
	Thu, 14 Feb 2002 15:50:02 -0500
Date: Wed, 13 Feb 2002 23:50:48 +0100
From: Pavel Machek <pavel@suse.cz>
To: Rob Landley <landley@trommello.org>
Cc: kernel list <linux-kernel@vger.kernel.org>
Subject: Re: small IDE cleanup: void * should not be used unless neccessary
Message-ID: <20020213225047.GI1454@elf.ucw.cz>
In-Reply-To: <20020211220937.GA121@elf.ucw.cz> <20020212224930.OKGN9845.femail25.sdc1.sfba.home.com@there> <20020213104731.GG32687@atrey.karlin.mff.cuni.cz> <20020213193835.CIGI23450.femail13.sdc1.sfba.home.com@there>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20020213193835.CIGI23450.femail13.sdc1.sfba.home.com@there>
User-Agent: Mutt/1.3.25i
X-Warning: Reading this can be dangerous to your mental health.
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

Hi!

> > > > This is really easy, please apply. (It will allow me to kill few casts
> > > > in future).
> > > > 								Pavel
> > > >
> > > > --- linux/include/linux/ide.h	Mon Feb 11 21:15:04 2002
> > > > +++ linux-dm/include/linux/ide.h	Mon Feb 11 22:36:12 2002
> > > > @@ -529,7 +531,7 @@
> > > >
> > > >  typedef struct hwif_s {
> > > >  	struct hwif_s	*next;		/* for linked-list in ide_hwgroup_t */
> > > > -	void		*hwgroup;	/* actually (ide_hwgroup_t *) */
> > > > +	struct hwgroup_s *hwgroup;	/* actually (ide_hwgroup_t *) */
> > > >  	ide_ioreg_t	io_ports[IDE_NR_PORTS];	/* task file registers */
> > > >  	hw_regs_t	hw;		/* Hardware info */
> > > >  	ide_drive_t	drives[MAX_DRIVES];	/* drive info */
> > >
> > > Now I'm confused about the comment on the end of the line.
> > >
> > > Should the comment be changed, or should the type be ide_hwgroup_t
> > > instead of struct hwgroup_s?
> >
> > struct hwgroup_s == ide_hwgroup_t. That's infection by hungarian
> > notation, and yes it would be nice to clean it up. For now, I'm
> > killing worst stuff.
> > 							Pavel
> 
> I know they're functionally equivalent, but so was the original void
> *. :)

Well, void * hides real errors.

> Just an "as long as you're touching this line anyway, why leave the old 
> comment?" thing.  A minor, in-passing nit at best...

ide_hwgroup_t is used in 90% of rest of code, so I thought I better
leave it there.
									Pavel
-- 
(about SSSCA) "I don't say this lightly.  However, I really think that the U.S.
no longer is classifiable as a democracy, but rather as a plutocracy." --hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/