Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754956AbZALRT4 (ORCPT ); Mon, 12 Jan 2009 12:19:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751117AbZALRTs (ORCPT ); Mon, 12 Jan 2009 12:19:48 -0500 Received: from ogre.sisk.pl ([217.79.144.158]:44758 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992AbZALRTr (ORCPT ); Mon, 12 Jan 2009 12:19:47 -0500 From: "Rafael J. Wysocki" To: "Zdenek Kabelac" Subject: Re: 2.6.29-rc1 does not resume on Lenove T61 Date: Mon, 12 Jan 2009 18:19:00 +0100 User-Agent: KMail/1.10.3 (Linux/2.6.28-rjw; KDE/4.1.3; x86_64; ; ) Cc: "Maciej Rutecki" , "Linux Kernel Mailing List" , "Henrique de Moraes Holschuh" References: <200901121340.21009.rjw@sisk.pl> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200901121819.01042.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3363 Lines: 91 On Monday 12 January 2009, Zdenek Kabelac wrote: > 2009/1/12 Rafael J. Wysocki : > > On Monday 12 January 2009, Zdenek Kabelac wrote: > >> 2009/1/12 Rafael J. Wysocki : > >> > On Sunday 11 January 2009, Zdenek Kabelac wrote: > >> >> 2009/1/11 Maciej Rutecki : > >> >> > 2009/1/11 Zdenek Kabelac : > >> >> >> Hi > >> >> >> > >> >> >> I've booted and tested 2.6.29-rc1 (c59765042f53a79a7a65585042ff463b69cb248c) > >> >> >> > >> >> >> I've observed that suspend is unusable - it goes to sleep - the sleep > >> >> >> LED is on. After few secs system turns on back itself - and stays in > >> >> >> some frozen state > >> >> > > >> >> > A have similar situation, one difference: I get blank screen during > >> >> > resume from suspend to ram. Also sometimes, like You, system turns on > >> >> > back itself. > >> >> > > >> >> > >> >> So it looks like reverting this commit: > >> >> > >> >> http://marc.info/?l=linux-kernel&m=123140019117968&w=4 > >> >> (6fd9086a518d4f14213a32fe6c9ac17fabebbc1e) > >> >> (which is already a tracked regression) > >> >> fixes the problem with auto-resume > >> >> > >> >> But the problem with deadlock in the resume phase is still there. > >> > > >> > Please check if unloading all of the USB controller modules before suspend > >> > helps. > >> > >> I've booted to single mode without usbcore module (thus any load of > >> other usb modules fails) > >> (removed from initramdisk as well) > >> > >> This time the resume stops with these 3 lines (I'm using > >> no_console_suspend kernel option): > >> > >> .... > >> thinkpad_acpi thinkpad_acpi: EARLY resume > >> thinkpad_hwmon thinkpad_hwmon: EARLY resume > >> Enabling non-boot CPUs... > > > > So it seems we have broken CPU hotplug again. > > > > Does disabling/enabling CPU1 using > > /sys/devices/system/cpu/cpu1/online work? > > > > If it does, please boot with 'no_console_suspend' in the kernel command line, > > run: > > > > # echo core > /sys/power/pm_test > > # echo 8 > /proc/sys/kernel/printk > > # echo mem > /sys/power/state > > > > and see what happens (you need to have PM_DEBUG set in the kernel .config). > > > > Please send dmesg output generated right after the above (if it works). > > > I've taken from another Ingo's thread the idea to revert patch: > > 7503bfbae89eba07b46441a5d1594647f6b8ab7d > > > With this patch reverted and o/e/uhci_hcd & usbhid modules removed > before pm-suspend > (usbcore could be loaded, I've not trace which one of those usb > modules makes the problem) > my system resumes properl again. Sure, good idea. I've been running with this reverted recently. > PS: I'll do the above 'echo' trace later (being busy right now). That shouldn't be necessary if you can suspend-resume with 7503bfbae89eba07b46441a5d1594647f6b8ab7d reverted and the USB controller modules unloaded. Instead, with 7503bfbae89eba07b46441a5d1594647f6b8ab7d reverted, please write 'disabled' to the /sys/devices/.../power/wakeup files of all USB controllers and see if suspend-resume works in this configuration. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/