Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755654AbZALRbu (ORCPT ); Mon, 12 Jan 2009 12:31:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751517AbZALRbg (ORCPT ); Mon, 12 Jan 2009 12:31:36 -0500 Received: from acsinet12.oracle.com ([141.146.126.234]:33195 "EHLO acsinet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751146AbZALRbf (ORCPT ); Mon, 12 Jan 2009 12:31:35 -0500 Subject: Re: [PATCH -v8][RFC] mutex: implement adaptive spinning From: Chris Mason To: Peter Zijlstra Cc: Linus Torvalds , Ingo Molnar , "Paul E. McKenney" , Gregory Haskins , Matthew Wilcox , Andi Kleen , Andrew Morton , Linux Kernel Mailing List , linux-fsdevel , linux-btrfs , Thomas Gleixner , Nick Piggin , Peter Morreale , Sven Dietrich , Dmitry Adamushko In-Reply-To: <1231781079.4371.198.camel@laptop> References: <1231774622.4371.96.camel@laptop> <1231778757.22806.24.camel@think.oraclecorp.com> <1231779015.4371.138.camel@laptop> <1231780491.22806.28.camel@think.oraclecorp.com> <1231781079.4371.198.camel@laptop> Content-Type: text/plain Date: Mon, 12 Jan 2009 12:30:12 -0500 Message-Id: <1231781412.22806.29.camel@think.oraclecorp.com> Mime-Version: 1.0 X-Mailer: Evolution 2.24.1 Content-Transfer-Encoding: 7bit X-Source-IP: acsmt702.oracle.com [141.146.40.80] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A0B0204.496B7E2D.02CF:SCFSTAT928724,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1491 Lines: 39 On Mon, 2009-01-12 at 18:24 +0100, Peter Zijlstra wrote: > On Mon, 2009-01-12 at 12:14 -0500, Chris Mason wrote: > > On Mon, 2009-01-12 at 17:50 +0100, Peter Zijlstra wrote: > > > > > > > > (the file stat run is total run time, so lower is better. The other > > > > numbers are files or MB per second, so higher is better) > > > > > > > > For the file create run, v8 had much lower system time than v7, > > > > averaging 1s of sys time per proc instead of 1.6s. > > > > > > Right, how about the spread in completion time, because that is the only > > > reason I tried this fairness stuff, because you reported massive > > > differences there. > > > > > > > I reran the numbers with a slightly different kernel config and they > > have changed somewhat. These are just for the 4k file create run, all > > numbers in files created per second (and the numbers are stable across > > runs) > > > > v8 avg 176.90 median 171.85 std 12.49 high 215.97 low 165.54 > > v7 avg 169.02 median 163.77 std 16.82 high 267.95 low 157.95 > > Any opinions on the fairness matter, will -v9 be unlocked and unfair > again? I'd rather have it simple than fair. My benchmarks are pretty dumb, I wouldn't want to add complexity just based on them. -chris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/