Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754298AbZALSUu (ORCPT ); Mon, 12 Jan 2009 13:20:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751387AbZALSUl (ORCPT ); Mon, 12 Jan 2009 13:20:41 -0500 Received: from relay1.sgi.com ([192.48.179.29]:50993 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750918AbZALSUk (ORCPT ); Mon, 12 Jan 2009 13:20:40 -0500 Message-ID: <496B89F4.7080406@sgi.com> Date: Mon, 12 Jan 2009 10:20:36 -0800 From: Mike Travis User-Agent: Thunderbird 2.0.0.6 (X11/20070801) MIME-Version: 1.0 To: Ingo Molnar CC: Christophe Saout , LKML Subject: Re: [PATCH]: xen: fix too early kmalloc call References: <496A4C8F.8070005@sgi.com> <20090112085302.GB21976@elte.hu> In-Reply-To: <20090112085302.GB21976@elte.hu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2738 Lines: 86 Ingo Molnar wrote: > * Mike Travis wrote: > >> Subject: xen: fix too early kmalloc call >> >> From: Christophe Saout >> >> Impact: fixes bootup of xen. >> >> Christophe reported the following problem: >> >>> (basically it seems that SLAB is not yet up, with earlyprintk it is >>> giving me an Oops in __kmalloc before) >> Replace call to kmalloc with alloc_bootmem. >> >> Also from Christophe: >>> (me) >>>> Or I could copy the text and submit it as a new patch? >>> Yes, I would prefer that. Also, my commit message was not really >>> following Kernel standards and it's only a very simple change. >> Signed-off-by: Mike Travis > > i've applied the fix to tip/cpus4096, in the form below. > > Please submit clean log messages. Your commit description was confused - > the patch is From: Christophe, but the message talks about Christophe in > the third person. Also, it included conversational bits that have no > value for the Git history. > > Ingo Ahh, ok, will do. I wasn't sure how many "liberties" we can take in submitting/changing something from someone else. THanks, Mike > > --------------------> >>From 28e08861b9afab4168b758fb7b95aa7a4da0f668 Mon Sep 17 00:00:00 2001 > From: Christophe Saout > Date: Sun, 11 Jan 2009 11:46:23 -0800 > Subject: [PATCH] xen: fix too early kmalloc call > > Impact: fix bootup crash on xen guests > > SLAB is not yet up, with earlyprintk it is giving me an Oops in __kmalloc. > > Replace call to kmalloc() with alloc_bootmem(). > > Reported-by: Christophe Saout > Signed-off-by: Mike Travis > Signed-off-by: Ingo Molnar > --- > drivers/xen/events.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/xen/events.c b/drivers/xen/events.c > index ed7527b..3141e14 100644 > --- a/drivers/xen/events.c > +++ b/drivers/xen/events.c > @@ -26,6 +26,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -831,8 +832,8 @@ void __init xen_init_IRQ(void) > int i; > size_t size = nr_cpu_ids * sizeof(struct cpu_evtchn_s); > > - cpu_evtchn_mask_p = kmalloc(size, GFP_KERNEL); > - BUG_ON(cpu_evtchn_mask == NULL); > + cpu_evtchn_mask_p = alloc_bootmem(size); > + BUG_ON(cpu_evtchn_mask_p == NULL); > > init_evtchn_cpu_bindings(); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/