Date: Mon, 12 Jan 2009 20:13:32 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Mike Travis <travis@sgi.com>
Cc: Christophe Saout <christophe@saout.de>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]: xen: fix too early kmalloc call
Message-ID: <20090112191332.GC15494@elte.hu>
References: <496A4C8F.8070005@sgi.com> <20090112085302.GB21976@elte.hu> <496B89F4.7080406@sgi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <496B89F4.7080406@sgi.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1244
Lines: 30


* Mike Travis <travis@sgi.com> wrote:

> > i've applied the fix to tip/cpus4096, in the form below.
> > 
> > Please submit clean log messages. Your commit description was confused 
> > - the patch is From: Christophe, but the message talks about 
> > Christophe in the third person. Also, it included conversational bits 
> > that have no value for the Git history.
> > 
> > 	Ingo
> 
> Ahh, ok, will do.  I wasn't sure how many "liberties" we can take in 
> submitting/changing something from someone else.

You are free to perfect anyone's commit log in essence - i do it for 90% 
of all commits that go via -tip. I fix tyops and grammar mistaiks in every 
second commit, and have to fix basic formatting, structure, explanations 
and reported-by credits and tags in most of them. Submitting patches with 
a well-structured commit log gives you extra credit :-)

[ Obviously you are not free to make a commit log worse and then make it 
  appear as if the guy who submitted it did it ;-) ]

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/