Date: Mon, 12 Jan 2009 11:23:51 -0800
From: Greg KH <gregkh@suse.de>
To: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Cc: Steve French <smfrench@gmail.com>, Randy Dunlap <randy.dunlap@oracle.com>,
       Stephen Rothwell <sfr@canb.auug.org.au>, linux-next@vger.kernel.org,
       LKML <linux-kernel@vger.kernel.org>, sfrench@samba.org
Subject: Re: linux-next: Tree for January 12 (cifs vs. staging)
Message-ID: <20090112192351.GA7607@suse.de>
References: <20090112154539.4857f533.sfr@canb.auug.org.au> <496B899E.7060605@oracle.com> <524f69650901121058g73c8022eif1d1bcca5c0e01fa@mail.gmail.com> <1231787958.6383.18.camel@norville.austin.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1231787958.6383.18.camel@norville.austin.ibm.com>
User-Agent: Mutt/1.5.16 (2007-06-09)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1265
Lines: 27

On Mon, Jan 12, 2009 at 01:19:18PM -0600, Dave Kleikamp wrote:
> On Mon, 2009-01-12 at 12:58 -0600, Steve French wrote:
> > There is not just the cifs md5 one (which has been around a long
> > time), but an md5_init (static) in crypto and the new one in rt.  The
> > addition of the new one (rt md5_init) causes the build problem.   It
> > would be nice if we could use the same md5 routines though ... last
> > time we checked the crypto one was not well suited for calculating
> > signatures as a network fs would do though.
> 
> Is that due to the byte-swapping?  Can the cifs and rt* drivers use the
> same code.  rt28[67]0/common/md5.c are identical files.  In fact those
> "common" directories should probably be combined into a single truly
> common directory.

Yes, the "common" directories are going to be merged, but as they
originally came from different driver sources, they didn't start out
that way.  It will take some refactoring to get it to work properly,
which is on my todo list...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/