Date: Mon, 12 Jan 2009 11:32:18 -0800
From: Greg KH <gregkh@suse.de>
To: Steve French <smfrench@gmail.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
       Stephen Rothwell <sfr@canb.auug.org.au>, linux-next@vger.kernel.org,
       LKML <linux-kernel@vger.kernel.org>, sfrench@samba.org
Subject: Re: linux-next: Tree for January 12 (cifs vs. staging)
Message-ID: <20090112193218.GA7751@suse.de>
References: <20090112154539.4857f533.sfr@canb.auug.org.au> <496B899E.7060605@oracle.com> <524f69650901121058g73c8022eif1d1bcca5c0e01fa@mail.gmail.com> <20090112191330.GC7111@suse.de> <524f69650901121123i1765dc3fye3ce636c91dd25bd@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <524f69650901121123i1765dc3fye3ce636c91dd25bd@mail.gmail.com>
User-Agent: Mutt/1.5.16 (2007-06-09)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 751
Lines: 21


A: No.
Q: Should I include quotations after my reply?

On Mon, Jan 12, 2009 at 01:23:07PM -0600, Steve French wrote:
> Is there some magic compile option alternative (other than renaming
> the function, which may be ok, since others probably don't depend on
> it)?  MD5Init is used outside fs/cifs/md5.c so can't be static

No, you should rename it to cifs_md5init to show that it is only for the
cifs module to use.  Try not to polute the global namespace with generic
function names.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/