Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762778AbZALWu3 (ORCPT ); Mon, 12 Jan 2009 17:50:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757430AbZALWb2 (ORCPT ); Mon, 12 Jan 2009 17:31:28 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:57853 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759162AbZALWb1 (ORCPT ); Mon, 12 Jan 2009 17:31:27 -0500 From: =?utf-8?q?Uwe=20Kleine-K=C3=B6nig?= To: linux-kernel@vger.kernel.org Date: Mon, 12 Jan 2009 23:25:06 +0100 Message-Id: <1231799107-20136-61-git-send-email-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 1.5.6.5 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: ukl@pengutronix.de Subject: [PATCH] move xilinx_spi's probe function to .devinit.text X-SA-Exim-Version: 4.2.1 (built Tue, 09 Jan 2007 17:23:22 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1350 Lines: 36 A pointer to xilinx_spi_probe is passed to the core via platform_driver_register and so the function must not disappear when the .init sections are discarded. Otherwise (if also having HOTPLUG=y) unbinding and binding a device to the driver via sysfs will result in an oops as does a device being registered late. An alternative to this patch is using platform_driver_probe instead of platform_driver_register plus removing the pointer to the probe function from the struct platform_driver. Signed-off-by: Uwe Kleine-König --- drivers/spi/xilinx_spi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/spi/xilinx_spi.c b/drivers/spi/xilinx_spi.c index 68d6f49..a5ca137 100644 --- a/drivers/spi/xilinx_spi.c +++ b/drivers/spi/xilinx_spi.c @@ -304,7 +304,7 @@ static irqreturn_t xilinx_spi_irq(int irq, void *dev_id) return IRQ_HANDLED; } -static int __init xilinx_spi_probe(struct platform_device *dev) +static int __devinit xilinx_spi_probe(struct platform_device *dev) { int ret = 0; struct spi_master *master; -- 1.5.6.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/