Date: Mon, 12 Jan 2009 23:40:37 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Andi Kleen <andi@firstfloor.org>
Cc: Frederik Deweerdt <frederik.deweerdt@xprog.eu>, tglx@linutronix.de,
       hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: [patch] tlb flush_data: replace per_cpu with an array
Message-ID: <20090112224037.GA16585@elte.hu>
References: <20090112213539.GA10720@gambetta> <20090112215701.GH23848@one.firstfloor.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090112215701.GH23848@one.firstfloor.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1517
Lines: 44


* Andi Kleen <andi@firstfloor.org> wrote:

> On Mon, Jan 12, 2009 at 10:35:42PM +0100, Frederik Deweerdt wrote:
> > Hi,
> > 
> > On x86_64 flush tlb data is stored in per_cpu variables. This is
> > unnecessary because only the first NUM_INVALIDATE_TLB_VECTORS entries
> > are accessed.
> >
> > This patch aims at making the code less confusing (there's nothing 
> > really "per_cpu") by using a plain array. It also would save some 
> > memory on most distros out there (Ubuntu x86_64 has NR_CPUS=64 by 
> > default).
> 
> Nope it doesn't save memory on most systems because per cpu is only 
> allocated based on the CPUs that are actually there. And if you have 
> more than 8 cores you can likely afford a few bytes per CPU.

No distro kernel will build with less than 8 CPUs anyway so this point is 
moot.

> You would need to cache line pad each entry then, otherwise you risk 
> false sharing. [...]

They are already cache line padded.

> [...] That would make the array 1K on 128 bytes cache line system.

512 bytes.

> [...]  This means on small systems this would actually waste much more 
> memory.

Really small systems will be UP and wont do cross-CPU TLB flushes, so if 
they are a worry the flush code can be UP optimized. (Nobody bothered so 
far.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/