Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757116AbZAMDKz (ORCPT ); Mon, 12 Jan 2009 22:10:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752089AbZAMDKq (ORCPT ); Mon, 12 Jan 2009 22:10:46 -0500 Received: from netrider.rowland.org ([192.131.102.5]:3661 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751989AbZAMDKp (ORCPT ); Mon, 12 Jan 2009 22:10:45 -0500 Date: Mon, 12 Jan 2009 22:10:43 -0500 (EST) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: "Rafael J. Wysocki" cc: Frans Pop , , , , , , , , ACPI Devel Maling List , Len Brown Subject: Re: [Regression] USB wakeup problem on Toshiba Portege R500 In-Reply-To: <200901122353.59887.rjw@sisk.pl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1728 Lines: 47 On Mon, 12 Jan 2009, Rafael J. Wysocki wrote: > On Monday 12 January 2009, Alan Stern wrote: > > On Fri, 9 Jan 2009, Rafael J. Wysocki wrote: > > > > > > My proposal: > > > > > > > > Devices and events that are clearly associated with system > > > > wakeup should be enabled by default. For example: Power > > > > button and laptop lid. > > > > > > Agreed. > > > > > > > All other devices capable of waking up the system should be > > > > disabled by default. This presumably includes every PCI > > > > device. If users want keyboard or mouse events to cause > > > > a system resume then they will have to configure their > > > > desktop management program to enable it. > > > > > > I generally agree, with one exception. There are network adapters which > > > can be enabled to wake up by the BIOS and their drivers set them up for WoL > > > currently on this basis. These should remain enabled IMO. > > > > How do we know which adapters these are? IMO the PCI core should > > disable wakeup by default for all devices when they are detected. > > This is what we do. > > > Is it sufficient to have the adapter drivers enable wakeup during > > their probe routines? > > Yes, it is. Therefore all we need is a patch to change the USB host controller drivers. They should call device_set_wakeup_capable() instead of device_init_wakeup(). I just got back from vacation so things will be busy for a few days, but I'll send out such a patch soon. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/