Date: Tue, 13 Jan 2009 15:13:07 +0900
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Rakib Mullick <rakib.mullick@gmail.com>,
       Linux-kernel Mailing List <linux-kernel@vger.kernel.org>, mingo@elte.hu,
       Andrew Morton <akpm@linux-foundation.org>,
       Balbir Singh <balbir@linux.vnet.ibm.com>
Subject: Re: [PATCH] mm: Fix section mismatch in memcontrol.c
Message-Id: <20090113151307.e9ddc085.kamezawa.hiroyu@jp.fujitsu.com>
In-Reply-To: <496C2B4F.3090406@cn.fujitsu.com>
References: <b9df5fa10901122139h4bfb727i64f864ec185c731d@mail.gmail.com>
	<496C2B4F.3090406@cn.fujitsu.com>
Organization: FUJITSU Co. LTD.
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1176
Lines: 38

On Tue, 13 Jan 2009 13:49:03 +0800
Li Zefan <lizf@cn.fujitsu.com> wrote:

> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
> 
> Rakib Mullick wrote:
> > Impact: Fix section mismatch warning.
> > 
> > The annotation for __init in enable_swap_cgroup() and __initdata for
> > really_do_swap_account produces the following warning. Which is not
> > right, since this function is called from non-init section. This patch
> > fixes it. If anything else please notice.
> > 
> 
> I saw this warning on IA64. But this fix is wrong IMO.
> 
> enable_swap_cgroup() will be called at system boot only:
> 
> start_kernel()
>   cgroup_init()
>     mem_cgroup_create()
>       enable_swap_cgroup()
> 
> I think the proper fix is annotate mem_cgroup_create() with __init_refok.
> 
I think Li Zefan's fix is correct. 
Could you make a patch ? or I'll schedule this as my work.

Thanks,
-Kame


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/