Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756030AbZAMHNo (ORCPT ); Tue, 13 Jan 2009 02:13:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752179AbZAMHNf (ORCPT ); Tue, 13 Jan 2009 02:13:35 -0500 Received: from pfepb.post.tele.dk ([195.41.46.236]:40145 "EHLO pfepb.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751626AbZAMHNe (ORCPT ); Tue, 13 Jan 2009 02:13:34 -0500 Date: Tue, 13 Jan 2009 08:15:13 +0100 From: Sam Ravnborg To: Jaswinder Singh Rajput Cc: Ingo Molnar , harvey.harrison@gmail.com, gorcunov@gmail.com, roque@di.fc.ul.pt, LKML , netdev Subject: Re: [PATCH -tip] in6.h: extern's make no sense in userspace Message-ID: <20090113071513.GB20036@uranus.ravnborg.org> References: <1231829859.3212.19.camel@jaswinder.satnam> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1231829859.3212.19.camel@jaswinder.satnam> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1454 Lines: 37 On Tue, Jan 13, 2009 at 12:27:39PM +0530, Jaswinder Singh Rajput wrote: > Impact: fix 2 make headers_check warnings: > > usr/include/linux/in6.h:47: extern's make no sense in userspace > usr/include/linux/in6.h:49: extern's make no sense in userspace > > Signed-off-by: Jaswinder Singh Rajput > --- > include/linux/in6.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/linux/in6.h b/include/linux/in6.h > index bc49204..718bf21 100644 > --- a/include/linux/in6.h > +++ b/include/linux/in6.h > @@ -44,11 +44,11 @@ struct in6_addr > * NOTE: Be aware the IN6ADDR_* constants and in6addr_* externals are defined > * in network byte order, not in host byte order as are the IPv4 equivalents > */ > +#ifdef __KERNEL__ > extern const struct in6_addr in6addr_any; > #define IN6ADDR_ANY_INIT { { { 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0 } } } > extern const struct in6_addr in6addr_loopback; > #define IN6ADDR_LOOPBACK_INIT { { { 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1 } } } > -#ifdef __KERNEL__ It looks wrong what IN6ADDR_ANY_INIT should be a kernel only symbol. At least google had some hits on that symbol. netdev people should know.... Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/