Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754405AbZAMLO1 (ORCPT ); Tue, 13 Jan 2009 06:14:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752564AbZAMLOR (ORCPT ); Tue, 13 Jan 2009 06:14:17 -0500 Received: from ogre.sisk.pl ([217.79.144.158]:49320 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752162AbZAMLOP (ORCPT ); Tue, 13 Jan 2009 06:14:15 -0500 From: "Rafael J. Wysocki" To: Alan Stern Subject: Re: [Regression] USB wakeup problem on Toshiba Portege R500 Date: Tue, 13 Jan 2009 12:13:25 +0100 User-Agent: KMail/1.10.3 (Linux/2.6.29-rc1-rjw; KDE/4.1.3; x86_64; ; ) Cc: Frans Pop , oliver@neukum.org, gregkh@suse.de, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-pm@lists.linux-foundation.org, pavel@suse.cz, torvalds@linux-foundation.org, ACPI Devel Maling List , Len Brown References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200901131213.26836.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1869 Lines: 49 On Tuesday 13 January 2009, Alan Stern wrote: > On Mon, 12 Jan 2009, Rafael J. Wysocki wrote: > > > On Monday 12 January 2009, Alan Stern wrote: > > > On Fri, 9 Jan 2009, Rafael J. Wysocki wrote: > > > > > > > > My proposal: > > > > > > > > > > Devices and events that are clearly associated with system > > > > > wakeup should be enabled by default. For example: Power > > > > > button and laptop lid. > > > > > > > > Agreed. > > > > > > > > > All other devices capable of waking up the system should be > > > > > disabled by default. This presumably includes every PCI > > > > > device. If users want keyboard or mouse events to cause > > > > > a system resume then they will have to configure their > > > > > desktop management program to enable it. > > > > > > > > I generally agree, with one exception. There are network adapters which > > > > can be enabled to wake up by the BIOS and their drivers set them up for WoL > > > > currently on this basis. These should remain enabled IMO. > > > > > > How do we know which adapters these are? IMO the PCI core should > > > disable wakeup by default for all devices when they are detected. > > > > This is what we do. > > > > > Is it sufficient to have the adapter drivers enable wakeup during > > > their probe routines? > > > > Yes, it is. > > Therefore all we need is a patch to change the USB host controller > drivers. They should call device_set_wakeup_capable() instead of > device_init_wakeup(). > > I just got back from vacation so things will be busy for a few days, > but I'll send out such a patch soon. Great, thanks a lot! Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/