Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760662AbZAMOpb (ORCPT ); Tue, 13 Jan 2009 09:45:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755135AbZAMOpV (ORCPT ); Tue, 13 Jan 2009 09:45:21 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:37109 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755536AbZAMOpT (ORCPT ); Tue, 13 Jan 2009 09:45:19 -0500 Date: Tue, 13 Jan 2009 15:45:05 +0100 From: Ingo Molnar To: Cyrill Gorcunov Cc: "H. Peter Anvin" , Thomas Gleixner , LKML , Harvey Harrison , Sam Ravnborg , Jaswinder Singh Rajput Subject: Re: [PATCH -tip] x86: headers - include linux/types.h instead of asm/types.h Message-ID: <20090113144505.GA4488@elte.hu> References: <20090113120905.GB7682@localhost> <20090113125705.GC7682@localhost> <20090113125928.GA31147@elte.hu> <20090113131020.GD7682@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090113131020.GD7682@localhost> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2035 Lines: 55 * Cyrill Gorcunov wrote: > [Ingo Molnar - Tue, Jan 13, 2009 at 01:59:28PM +0100] > | > | * Cyrill Gorcunov wrote: > | > | > [Cyrill Gorcunov - Tue, Jan 13, 2009 at 03:09:05PM +0300] > | > | Impact: cleanup > | > | > | > | 'make headers_check' warns that linux/types.h is > | > | preferred over asm/types.h. So be it. > | > | > | > | Signed-off-by: Cyrill Gorcunov > | > | CC: Jaswinder Singh Rajput > | > | CC: Sam Ravnborg > | > | CC: Harvey Harrison > | > | --- > | > | > | > | arch/x86/include/asm/e820.h | 2 ++ > | > | arch/x86/include/asm/kvm.h | 2 +- > | > | arch/x86/include/asm/mce.h | 2 +- > | > | arch/x86/include/asm/mtrr.h | 1 + > | > | arch/x86/include/asm/ptrace-abi.h | 2 +- > | > | arch/x86/include/asm/sigcontext.h | 2 +- > | > | arch/x86/include/asm/swab.h | 2 +- > | > | 7 files changed, 8 insertions(+), 5 deletions(-) > | > | > | > ... > | > > | > well... on the other hand I'm not sure if it's really > | > a good idea to include linux/types.h where we need only > | > __u[8,16] and so on definitions. > | > | Well, linux/types.h is supposed to be a 'lightweight', 'core data types > | only' kind of header file, so including it is not wrong per se. > | > | Sam, is there some other preferred way perhaps to resolve these? > | > | Ingo > | > > Until such a file not passed to some *.S. For example for e820.h we have > it included to arch/x86/boot/header.S but fortunately we're bound by > __ASSEMBLY__. So there linux/types.h shouldn't hurt. Will check others > and report then. Any reason to not protect types.h with #ifndef __ASSEMBLY__ ? Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/