Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758653AbZAMSkV (ORCPT ); Tue, 13 Jan 2009 13:40:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753739AbZAMSkE (ORCPT ); Tue, 13 Jan 2009 13:40:04 -0500 Received: from mms1.broadcom.com ([216.31.210.17]:4740 "EHLO mms1.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751667AbZAMSkB (ORCPT ); Tue, 13 Jan 2009 13:40:01 -0500 X-Server-Uuid: 02CED230-5797-4B57-9875-D5D2FEE4708A Date: Tue, 13 Jan 2009 10:39:48 -0800 From: "Matt Carlson" To: "David Miller" cc: "dwmw2@infradead.org" , "Valdis.Kletnieks@vt.edu" , "alessandro.suardi@gmail.com" , "jaswinderlinux@gmail.com" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: 2.6.28-git8: tg3 doesn't work due to firmware not loading (-git7 is ok) Message-ID: <20090113183948.GA21847@xw6200.broadcom.net> References: <43805.1231672258@turing-police.cc.vt.edu> <20090111.040842.86784676.davem@davemloft.net> <1231676698.25018.147.camel@macbook.infradead.org> <20090111.133929.57600645.davem@davemloft.net> MIME-Version: 1.0 In-Reply-To: <20090111.133929.57600645.davem@davemloft.net> User-Agent: Mutt/1.5.16 (2007-06-09) X-WSS-ID: 6572007D61S33778676-01-01 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1290 Lines: 27 On Sun, Jan 11, 2009 at 01:39:29PM -0800, David Miller wrote: > From: David Woodhouse > Date: Sun, 11 Jan 2009 12:24:58 +0000 > > > Other drivers will load the firmware later, at the time the device is > > brought up. This means that even if you build the driver into the kernel > > without its firmware, it can still request the firmware later, when you > > try to start _using_ it. And when the file system is available. > > For example, for mounting an NFS root using that device.... Oh, will I > need an initramfs for that once you pull the firmware-in-kernel > option? > > To me, device probe is in fact the place to fail firmware discovery > for networking devices. Because such a failure can mean you can't > mount your root filesystem. David, is this the direction you want to take the fix? I'm sitting on a patch that elaborates on David Woodhouse's work which moves the request_firmware call to tg3_open(). Before I posted it for comment, I wanted to make sure the patch is moving in the right direction. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/