Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756622AbZAMUzx (ORCPT ); Tue, 13 Jan 2009 15:55:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752179AbZAMUzn (ORCPT ); Tue, 13 Jan 2009 15:55:43 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:39376 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751599AbZAMUzm (ORCPT ); Tue, 13 Jan 2009 15:55:42 -0500 Date: Tue, 13 Jan 2009 12:54:35 -0800 From: Andrew Morton To: Joe Perches Cc: torvalds@linux-foundation.org, pavel@ucw.cz, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/10] MAINTAINERS - script, patterns, and misc fixes Message-Id: <20090113125435.4821123a.akpm@linux-foundation.org> In-Reply-To: <1231878498-25171-1-git-send-email-joe@perches.com> References: <1231878498-25171-1-git-send-email-joe@perches.com> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3794 Lines: 170 On Tue, 13 Jan 2009 12:28:08 -0800 Joe Perches wrote: > This patchset adds a script to find the maintainer > of an individual file or files in a patch and > additional patterns to MAINTAINERS. > > Other information from MAINTAINERS sections can > also be generated by file or patch. I applaud the intent. This patchset is basically unmergeable by anyone except Linus - it already gets three rejects against half-hour-old mainline. We need to ensure that scripts/get_maintainer.pl gets its "x" bit set, somehow (you lose it if you just apply the patch). Perhaps the instructions should say perl scripts/get_maintainer.pl ... rather than just scripts/get_maintainer.pl ... How does it work, anyway? akpm:/usr/src/git26> ../25/scripts/get_maintainer.pl -f mm/filemap.c Balbir Singh Hugh Dickins KAMEZAWA Hiroyuki Miklos Szeredi Nick Piggin I think Balbir would be surprised! akpm:/usr/src/git26> ../25/scripts/get_maintainer.pl -f fs/ext3/super.c Aneesh Kumar K.V Christoph Hellwig Jan Blunck Jan Kara Marcin Slusarz mm.. spose so, but it isn't terribly accurate. Does it take signed-off-by:s and/or the git Commit: header into account? akpm:/usr/src/git26> ../25/scripts/get_maintainer.pl -f fs/xfs/xfs.h Christoph Hellwig Donald Douwsma Eric Sandeen Lachlan McIlroy Tim Shimmin OK, that was an easy case. It's a bit slow. That's git's fault. Perhaps some git person will be able to suggest ways of speeding it up. akpm:/usr/src/git26> ../25/scripts/get_maintainer.pl -f mm/pdflush.c Ingo Molnar Jesper Juhl Mike Travis OGAWA Hirofumi Pavel Machek again, not the result I'd have expected! But I guess we can fine-tune these thnigs after we get the bulk of it settled in. My script generates what I consider to be better results: akpm:/usr/src/25> who-maintains.sh mm/filemap.c Nick Piggin Hugh Dickins Fengguang Wu Christoph Hellwig Steven Whitehouse Zach Brown Miklos Szeredi Jan Kara Balbir Singh Badari Pulavarty For some (git related) reason it is vastly slower than yours. #!/bin/sh # # Usage: who-maintains.sh file1 file2 .. # TMP=$(mktemp /tmp/who-maintains-XXXXXX) TMP2=$(mktemp /tmp/who-maintains2-XXXXXX) TMP=/tmp/1 TMP2=/tmp/2 GITDIR=/usr/src/git26 cd $GITDIR FILES="" for i in $* do if [ -e $i ] then FILES=$FILES" $i" fi done if [ x"$FILES" == "x" ] then exit 0 fi git whatchanged $FILES > $TMP cat $TMP | ( egrep "Author:|Signed-off-by:" | grep -v torvalds | grep -v akpm | sed -e 's/^[ ]*//' | sed -e 's/Signed-off-by:[ ]*//' | sed -e 's/Author:[ ]*//' | sort ) > $TMP2 LAST="" COUNT=0 grokkit() { while read NAME do if [ "$NAME" == "$LAST" ] then COUNT=$(expr $COUNT + 1) else if [ x"$LAST" != "x" ] then echo $COUNT $LAST fi LAST="$NAME" COUNT=1 fi done if [ x"$LAST" != "x" ] then echo $COUNT $LAST fi } grokkit < $TMP2 | sort -nr | head -n 10 | sed -e 's/[0-9]* //' #rm -f $TMP $TMP2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/