Date: Tue, 13 Jan 2009 13:10:30 -0800 (PST)
Message-Id: <20090113.131030.207355839.davem@davemloft.net>
To: jesper.nilsson@axis.com
Cc: tj@kernel.org, gregkh@suse.de, stern@rowland.harvard.edu,
       jens.axboe@oracle.com, hinko.kocevar@cetrtapot.si,
       linux-kernel@vger.kernel.org
Subject: Re: lib/klist.c: bit 0 in pointer can't be used as flag
From: David Miller <davem@davemloft.net>
In-Reply-To: <20090113151406.GC19262@axis.com>
References: <20090113151406.GC19262@axis.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 831
Lines: 19

From: Jesper Nilsson <jesper.nilsson@axis.com>
Date: Tue, 13 Jan 2009 16:14:06 +0100

> The commit a1ed5b0cffe4b16a93a6a3390e8cee0fbef94f86
> (klist: don't iterate over deleted entries) introduces use of the
> low bit in a pointer to indicate if the knode is dead or not,
> assuming that this bit is always free.
> 
> This is not true for all architectures, CRIS for example may align data
> on byte borders.

There are many other spots in the kernel where the low bits of a
pointer are hijacked as status bits.  Lots of other things cannot
possible be working on CRIS because of this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/