Date: Wed, 14 Jan 2009 00:33:23 +0000 (GMT)
From: Hugh Dickins <hugh@veritas.com>
To: David Miller <davem@davemloft.net>
cc: kosaki.motohiro@jp.fujitsu.com, Jesper.Nilsson@axis.com, tj@kernel.org,
       gregkh@suse.de, stern@rowland.harvard.edu, jens.axboe@oracle.com,
       hinko.kocevar@cetrtapot.si, linux-kernel@vger.kernel.org
Subject: Re: lib/klist.c: bit 0 in pointer can't be used as flag
In-Reply-To: <20090113.144521.97357573.davem@davemloft.net>
Message-ID: <Pine.LNX.4.64.0901140026240.3808@blonde.anvils>
References: <20090113.131030.207355839.davem@davemloft.net>
 <20090113221235.GD19262@axis.com> <2f11576a0901131440w7fd3290uc9664aaf7aa89b08@mail.gmail.com>
 <20090113.144521.97357573.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1152
Lines: 29

On Tue, 13 Jan 2009, David Miller wrote:
> From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Date: Wed, 14 Jan 2009 07:40:19 +0900
> 
> > > It may be that we've worked around the other spots, although I haven't
> > > seen anything like that, we might just have been lucky until now.
> > >
> > > Can you recall another place where this trick is used?
> > 
> > rmap.
> > Don't CRIS use mmu?
> 
> I'm beginning to suspect the issue is only with objects
> in the kernel image itself.  Dynamically allocated memory
> is properly aligned and therefore the "low bit status bits
> in pointer" trick works.

Yes: I don't think we fully realized that when adding the
__attribute__((aligned(sizeof(long)))) to struct address_space
(so the PAGE_MAPPING_ANON bit didn't mess up on CRIS), but the
only instance which actually gave a problem was the peculiar
struct swapper_space declared in mm/swap_state.c.

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/