Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760767AbZANIeT (ORCPT ); Wed, 14 Jan 2009 03:34:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754081AbZANIeH (ORCPT ); Wed, 14 Jan 2009 03:34:07 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:49424 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756669AbZANIeE (ORCPT ); Wed, 14 Jan 2009 03:34:04 -0500 Date: Wed, 14 Jan 2009 00:32:34 -0800 From: Andrew Morton To: Masami Hiramatsu Cc: Ananth N Mavinakayanahalli , Jim Keniston , David Miller , LKML , systemtap-ml Subject: Re: [PATCH][bugfix] kprobes: fix module compilation error with CONFIG_KPROBES=n Message-Id: <20090114003234.3720e9a1.akpm@linux-foundation.org> In-Reply-To: <49628849.1000706@redhat.com> References: <49628849.1000706@redhat.com> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1293 Lines: 35 On Mon, 05 Jan 2009 17:23:05 -0500 Masami Hiramatsu wrote: > Define kprobes related data structures even if CONFIG_KPROBES is not set. > This fixes compilation errors which occur if CONFIG_KPROBES is not set, in > kprobe using modules. > > Reviewed-by: Ananth N Mavinakayanahalli > Signed-off-by: Masami Hiramatsu > --- > include/linux/kprobes.h | 45 +++++++++++++++++++++++---------------------- > 1 file changed, 23 insertions(+), 22 deletions(-) > > Index: 2.6.28/include/linux/kprobes.h > =================================================================== > --- 2.6.28.orig/include/linux/kprobes.h > +++ 2.6.28/include/linux/kprobes.h > @@ -37,9 +37,9 @@ > #include > #include > #include > +#include > > #ifdef CONFIG_KPROBES > -#include > The above change breaks alpha, and any other architecture which has no asm/kprobes.h. I undid that change, but maybe that rebroke things? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/