Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761357AbZANJKe (ORCPT ); Wed, 14 Jan 2009 04:10:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753721AbZANJKJ (ORCPT ); Wed, 14 Jan 2009 04:10:09 -0500 Received: from mx2.suse.de ([195.135.220.15]:37184 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752805AbZANJKE (ORCPT ); Wed, 14 Jan 2009 04:10:04 -0500 Date: Wed, 14 Jan 2009 10:09:59 +0100 Message-ID: From: Takashi Iwai To: Kyle McMartin Cc: rusty@rustcorp.com.au, linux-kernel@vger.kernel.org Subject: Re: [PATCH] module: kzalloc mod->ref In-Reply-To: <20090114033533.GL25103@bombadil.infradead.org> References: <20090114033533.GL25103@bombadil.infradead.org> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1051 Lines: 32 At Tue, 13 Jan 2009 22:35:33 -0500, Kyle McMartin wrote: > > From: Kyle McMartin > > Dynamically allocate mod->ref instead of fixing it in the struct module. > Reduces on disk space wasted in the module .ko, and kills a loop > initializing the local_t it contains since we can just kzalloc it. > > This matters when we're talking about large NR_CPUS. > > Signed-off-by: Kyle McMartin > --- > The patch removing cacheline_aligned from struct module_ref should be > applied as well to cut down on the amount of memory we allocate. This > patch makes a nice stopgap until we have per_cpu module references. > > cheers, Kyle Similar patches (including mine) have been already posted, but no proceed until now... http://lkml.org/lkml/2008/11/11/315 thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/