Message-ID: <496DBB25.9040101@rsk.demon.co.uk>
Date: Wed, 14 Jan 2009 10:15:01 +0000
From: richard kennedy <richard@rsk.demon.co.uk>
User-Agent: Thunderbird 2.0.0.19 (X11/20090105)
MIME-Version: 1.0
To: Kyle McMartin <kyle@infradead.org>
CC: rusty@rustcorp.com.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] module: kzalloc mod->ref
References: <20090114033533.GL25103@bombadil.infradead.org>
In-Reply-To: <20090114033533.GL25103@bombadil.infradead.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1154
Lines: 32

Kyle McMartin wrote:
> From: Kyle McMartin <kyle@redhat.com>
> 
> Dynamically allocate mod->ref instead of fixing it in the struct module.
> Reduces on disk space wasted in the module .ko, and kills a loop
> initializing the local_t it contains since we can just kzalloc it.
> 
> This matters when we're talking about large NR_CPUS.
> 
> Signed-off-by: Kyle McMartin <kyle@redhat.com>
> ---
> The patch removing cacheline_aligned from struct module_ref should be
> applied as well to cut down on the amount of memory we allocate. This
> patch makes a nice stopgap until we have per_cpu module references.
> 
> cheers, Kyle
> 
Hi Kyle,

As module_get/ put use module_ref as a per_cpu variable won't removing
the cacheline_aligned be a performance hit due to cacheline sharing on
machines with reasonable or small number of cpus?

(some of the network code seems to call module_get/put a lot!)

regards
Richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/