Date: Wed, 14 Jan 2009 18:11:32 +0300
From: Evgeniy Polyakov <zbr@ioremap.net>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Greg KH <greg@kroah.com>, linux-kernel@vger.kernel.org, dst@ioremap.net
Subject: Re: [3/7] dst: export node.
Message-ID: <20090114151132.GB6419@ioremap.net>
References: <1231887933-17843-1-git-send-email-zbr@ioremap.net> <1231887933-17843-2-git-send-email-zbr@ioremap.net> <1231887933-17843-3-git-send-email-zbr@ioremap.net> <1231887933-17843-4-git-send-email-zbr@ioremap.net> <20090114145204.GE30821@kernel.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090114145204.GE30821@kernel.dk>
User-Agent: Mutt/1.5.13 (2006-08-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 974
Lines: 29

On Wed, Jan 14, 2009 at 03:52:05PM +0100, Jens Axboe (jens.axboe@oracle.com) wrote:
> On Wed, Jan 14 2009, Evgeniy Polyakov wrote:
> > +	bio = bio_alloc_bioset(GFP_KERNEL,
> > +			PAGE_ALIGN(cmd->size) >> PAGE_SHIFT,
> > +			dst_bio_set);
> > +	if (!bio)
> > +		goto err_out_exit;
> > +	bio->bi_private = NULL;
> > +
> > +	priv = mempool_alloc(st->node->trans_pool, GFP_KERNEL);
> > +	if (!priv)
> > +		goto err_out_free;
> 
> Did you know that you can now set the appropriate extra size for your
> private bio set, thus getting rid of this extra 'priv' allocation and
> free for each bio?
> 
> See bioset_create().

Yes, that's a good idea, I will update the patch with that changes in
mind. Thanks Jens.

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/