Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763657AbZANP72 (ORCPT ); Wed, 14 Jan 2009 10:59:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761336AbZANP7H (ORCPT ); Wed, 14 Jan 2009 10:59:07 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:60102 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760869AbZANP7F (ORCPT ); Wed, 14 Jan 2009 10:59:05 -0500 Date: Wed, 14 Jan 2009 10:58:59 -0500 From: Kyle McMartin To: Takashi Iwai Cc: Kyle McMartin , rusty@rustcorp.com.au, linux-kernel@vger.kernel.org Subject: Re: [PATCH] module: kzalloc mod->ref Message-ID: <20090114155859.GO25103@bombadil.infradead.org> References: <20090114033533.GL25103@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1483 Lines: 39 On Wed, Jan 14, 2009 at 10:09:59AM +0100, Takashi Iwai wrote: > At Tue, 13 Jan 2009 22:35:33 -0500, > Kyle McMartin wrote: > > > > From: Kyle McMartin > > > > Dynamically allocate mod->ref instead of fixing it in the struct module. > > Reduces on disk space wasted in the module .ko, and kills a loop > > initializing the local_t it contains since we can just kzalloc it. > > > > This matters when we're talking about large NR_CPUS. > > > > Signed-off-by: Kyle McMartin > > --- > > The patch removing cacheline_aligned from struct module_ref should be > > applied as well to cut down on the amount of memory we allocate. This > > patch makes a nice stopgap until we have per_cpu module references. > > > > cheers, Kyle > > Similar patches (including mine) have been already posted, but no > proceed until now... > http://lkml.org/lkml/2008/11/11/315 Ah, sigh. It would be nice to get this sorted out, since we're serious wasting disk space for no good reason... Although as Richard points out, dropping the cacheline_aligned might drop networking performance (which, sigh, is also stupid) but allocating 128b * NR_CPUS is just a ridiculous amount of memory to waste for a reference count... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/