Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763906AbZANQAN (ORCPT ); Wed, 14 Jan 2009 11:00:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763715AbZANP7i (ORCPT ); Wed, 14 Jan 2009 10:59:38 -0500 Received: from wa-out-1112.google.com ([209.85.146.180]:7701 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756711AbZANP7g (ORCPT ); Wed, 14 Jan 2009 10:59:36 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=YJU5irDxSdyC/HZv6GG5tUIkJ2Dajr0unNc3zv70vIYia8J0hB3vcutZZKmWUeS9Xb QoFDwIDrkX+iPpzGtfADi7CyvAvy+ceb/Xq3BB9gJCzFlMHjJF7wwDjgM5IDA+iNr4ZZ Wth5jsoqJyxcYSfD8PlTBfSk6vRwD0th57xNI= MIME-Version: 1.0 In-Reply-To: <20090114153825.GB32082@uranus.ravnborg.org> References: <1231836016.3212.41.camel@jaswinder.satnam> <3f9a31f40901140129i1389f47frf32808f3a695a118@mail.gmail.com> <20090114153825.GB32082@uranus.ravnborg.org> Date: Wed, 14 Jan 2009 21:29:35 +0530 Message-ID: <3f9a31f40901140759s1542e6cclae1808b796c2b1a9@mail.gmail.com> Subject: Re: [PULL -tip] fixed few make headers_check warnings From: Jaswinder Singh Rajput To: Sam Ravnborg Cc: Geert Uytterhoeven , Jaswinder Singh Rajput , Ingo Molnar , Alan Cox , Andrew Morton , David Miller , x86 maintainers , LKML , netdev Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1215 Lines: 35 Hello Sam, On Wed, Jan 14, 2009 at 9:08 PM, Sam Ravnborg wrote: >> > > > I appreciate your work but I will like to question the approach. My approach was: "PATCH should solve a problem per file", like: capability.h: extern's make no sense in userspace coda_psdev.h: extern's make no sense in userspace in6.h: extern's make no sense in userspace nubus.h: extern's make no sense in userspace socket.h: extern's make no sense in userspace But this warnings was in many files: include of is preferred over : 15 files found __[us]{8,16,32,64} type without #include : 52 files So in place of making 15 + 52 = 67 patches, I made 2 patches for each warning. > We should rather take the warnings as an indication that this > file needs to be looked over and fix not only the warnings > reported but rater to fix all the questionable issues on a file-by-file basis. Should I make 67 patches ? -- JSR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/