Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764724AbZANQ6j (ORCPT ); Wed, 14 Jan 2009 11:58:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1764626AbZANQ6W (ORCPT ); Wed, 14 Jan 2009 11:58:22 -0500 Received: from wa-out-1112.google.com ([209.85.146.177]:14083 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762845AbZANQ6U (ORCPT ); Wed, 14 Jan 2009 11:58:20 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=OedbwsHpHoV6otHFLHnYskyX3yH2r+80RM7m8XTzAAUnckb6GZwKpSGrIyksVLo0TU pktkTSqnKiCcxuppR4g3n4e9LGFJ9ivDPLFhLiX65cwcO5ISAJnrQa9nKjTmEsB5Psux UvZZpYGepYKajvzsUdxjWMzekUx3lTJHEAfS0= MIME-Version: 1.0 In-Reply-To: References: <1231836016.3212.41.camel@jaswinder.satnam> <3f9a31f40901140129i1389f47frf32808f3a695a118@mail.gmail.com> <20090114153825.GB32082@uranus.ravnborg.org> <3f9a31f40901140759s1542e6cclae1808b796c2b1a9@mail.gmail.com> Date: Wed, 14 Jan 2009 22:28:19 +0530 Message-ID: <3f9a31f40901140858w3a024023h94ebb1a6e087d03e@mail.gmail.com> Subject: Re: [PULL -tip] fixed few make headers_check warnings From: Jaswinder Singh Rajput To: Geert Uytterhoeven Cc: Sam Ravnborg , Jaswinder Singh Rajput , Ingo Molnar , Alan Cox , Andrew Morton , David Miller , x86 maintainers , LKML , netdev Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 994 Lines: 23 On Wed, Jan 14, 2009 at 10:06 PM, Geert Uytterhoeven wrote: > What Sam means is that the warnings about externs not making sense in userspace > are indicators that there may be other external declarations (without "extern") > in those files, and that you should fix those at the same time (i.e. either > don't fix any of them, or fix all of them (in the same file)). If you don't > fix them at the same time, people tend to forget about them. > > So the warnings are just considered canaries in our coal mine. Killing only the > canaries doesn't help. > If this is the case, then drop extern patches and let maintainers of those files should handle them then they will not forget and never repeat this mistake again. -- JSR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/