Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764721AbZANRJ1 (ORCPT ); Wed, 14 Jan 2009 12:09:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763675AbZANRJB (ORCPT ); Wed, 14 Jan 2009 12:09:01 -0500 Received: from wa-out-1112.google.com ([209.85.146.180]:14792 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1765048AbZANRI4 (ORCPT ); Wed, 14 Jan 2009 12:08:56 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=LrMu9xtxJXTGIxkfoJtj0PeHm7rXDDF7kMohvKZxxGnhPOU9J13mZcxbdQSUWCNfK6 vo7J+C7gBAmTOM2XIlwNjYagOq1180XVEDAI33APO6mLegfRgyifYv5M723mj5rxx1k1 twyJIbrcoK/uCDz2bHg/0ZhItcv8w1luuJPkQ= MIME-Version: 1.0 In-Reply-To: References: <1231862386-11128-1-git-send-email-Geert.Uytterhoeven@sonycom.com> <1231862386-11128-2-git-send-email-Geert.Uytterhoeven@sonycom.com> <3f9a31f40901140845r6a0cd136ha27304c76001d1c7@mail.gmail.com> Date: Wed, 14 Jan 2009 22:38:55 +0530 Message-ID: <3f9a31f40901140908v6da1e28cpeb951d162433d82c@mail.gmail.com> Subject: Re: [PATCH] crypto: compress - Add pcomp interface From: Jaswinder Singh Rajput To: Geert Uytterhoeven Cc: Herbert Xu , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2810 Lines: 70 On Wed, Jan 14, 2009 at 10:24 PM, Geert Uytterhoeven wrote: > On Wed, 14 Jan 2009, Jaswinder Singh Rajput wrote: >> On Tue, Jan 13, 2009 at 9:29 PM, Geert Uytterhoeven >> wrote: >> > +static inline struct pcomp_alg *crypto_pcomp_alg(struct crypto_pcomp *tfm) >> > +{ >> > + return __crypto_pcomp_alg(crypto_pcomp_tfm(tfm)->__crt_alg); >> > +} >> > + >> > +static inline int crypto_pcomp_setup(struct crypto_pcomp *tfm, >> > + const void *params) >> > +{ >> > + return crypto_pcomp_alg(tfm)->setup(crypto_pcomp_tfm(tfm), params); >> > +} >> > + >> > +static inline int crypto_pcomp_compress_init(struct crypto_pcomp *tfm) >> > +{ >> > + return crypto_pcomp_alg(tfm)->compress_init(crypto_pcomp_tfm(tfm)); >> > +} >> > + >> > +static inline int crypto_pcomp_compress_update(struct crypto_pcomp *tfm, >> > + struct comp_request *req) >> > +{ >> > + return crypto_pcomp_alg(tfm)->compress_update(crypto_pcomp_tfm(tfm), >> > + req); >> > +} >> > + >> > +static inline int crypto_pcomp_compress_final(struct crypto_pcomp *tfm, >> > + struct comp_request *req) >> > +{ >> > + return crypto_pcomp_alg(tfm)->compress_final(crypto_pcomp_tfm(tfm), >> > + req); >> > +} >> > + >> > +static inline int crypto_pcomp_decompress_init(struct crypto_pcomp *tfm) >> > +{ >> > + return crypto_pcomp_alg(tfm)->decompress_init(crypto_pcomp_tfm(tfm)); >> > +} >> > + >> > +static inline int crypto_pcomp_decompress_update(struct crypto_pcomp *tfm, >> > + struct comp_request *req) >> > +{ >> > + return crypto_pcomp_alg(tfm)->decompress_update(crypto_pcomp_tfm(tfm), >> > + req); >> > +} >> > + >> > +static inline int crypto_pcomp_decompress_final(struct crypto_pcomp *tfm, >> > + struct comp_request *req) >> > +{ >> > + return crypto_pcomp_alg(tfm)->decompress_final(crypto_pcomp_tfm(tfm), >> > + req); >> > +} >> >> Can you please use expressive but short names ? > > I admit they're quite long. But they're similar to the ones in use for the > already existing crypto modules. > But I am expecting better results from you ;-) Thanks -- JSR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/