Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760158AbZANVjf (ORCPT ); Wed, 14 Jan 2009 16:39:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756116AbZANVj0 (ORCPT ); Wed, 14 Jan 2009 16:39:26 -0500 Received: from mx0.towertech.it ([213.215.222.73]:53519 "HELO mx0.towertech.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755497AbZANVjZ (ORCPT ); Wed, 14 Jan 2009 16:39:25 -0500 Date: Wed, 14 Jan 2009 22:39:19 +0100 From: Alessandro Zummo To: rtc-linux@googlegroups.com Cc: akpm@linux-foundation.org, dann frazier , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, eranian@googlemail.com Subject: Re: [rtc-linux] Re: [PATCH] add rtc platform driver for EFI Message-ID: <20090114223919.120405f6@i1501.lan.towertech.it> In-Reply-To: <20090114132554.1efce88f.akpm@linux-foundation.org> References: <20090109005644.GH32403@ldl.fc.hp.com> <20090109032729.6e4cd5fd@i1501.lan.towertech.it> <20090109213615.GD31548@ldl.fc.hp.com> <20090113003934.0a7da676.akpm@linux-foundation.org> <20090114000043.GB24423@colo.lackof.org> <20090114011719.GD24423@colo.lackof.org> <20090114023055.1d22d09e@i1501.lan.towertech.it> <20090114041358.GA21357@ldl.fc.hp.com> <20090114043337.GB21357@ldl.fc.hp.com> <20090114115728.15f2db18@i1501.lan.towertech.it> <20090114173745.GA24492@ldl.fc.hp.com> <20090114132554.1efce88f.akpm@linux-foundation.org> Organization: Tower Technologies X-Mailer: Sylpheed X-This-Is-A-Real-Message: Yes Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 821 Lines: 31 On Wed, 14 Jan 2009 13:25:54 -0800 Andrew Morton wrote: > From: Andrew Morton > > - the LEAP_YEAR macro is buggy - it references its arg multiple times. > Fix this by turning it into a C function. > > - give it a more approriate name > > - Move it to rtc.h so that other .c files can use it, instead of copying it. Seems nice! I'll send to Linus :)))) Acked-by: Alessandro Zummo -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/