Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762009AbZAOHeA (ORCPT ); Thu, 15 Jan 2009 02:34:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756364AbZAOHds (ORCPT ); Thu, 15 Jan 2009 02:33:48 -0500 Received: from nacho.alt.net ([208.90.169.18]:39942 "EHLO nacho.alt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756320AbZAOHdr (ORCPT ); Thu, 15 Jan 2009 02:33:47 -0500 X-Greylist: delayed 400 seconds by postgrey-1.27 at vger.kernel.org; Thu, 15 Jan 2009 02:33:47 EST Date: Thu, 15 Jan 2009 07:26:28 +0000 (UTC) To: Jarek Poplawski cc: Peter Zijlstra , Denys Fedoryschenko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Badalian Vyacheslav , Thomas Gleixner Subject: Re: deadlocks if use htb In-Reply-To: <20090115065322.GA4190@ff.dom.local> Message-ID: References: <20081010090426.GA6054@ff.dom.local> <20090114063909.GA4234@ff.dom.local> <200901141417.58667.denys@visp.net.lb> <1231937404.14825.4.camel@laptop> <20090115065322.GA4190@ff.dom.local> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Delivery-Agent: TMDA/1.1.4 (Edradour) From: Chris Caputo Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2031 Lines: 48 On Thu, 15 Jan 2009, Jarek Poplawski wrote: > On Wed, Jan 14, 2009 at 06:02:04PM +0000, Chris Caputo wrote: > ... > > That said, I would not recommend just the three for -stable unless they > > get a much wider amount of testing, on multiple platforms. I don't see > > that as likely to happen, plus Peter says they are incomplete, so maybe it > > is just best to recommend that 2.6.28 users getting crashes while using > > HTB try these specific patches at first, and then the rest of the patches > > if they do not work. > > The main problem is my patches, at least the tested ones, harm htb's > exactness, and I doubt I could convince anybody to merege them, at > least before your case. It was only reported by two users here (plus > one more on private), and looked like something very rare. After your > report it looks much more necessary. > > If there is nothing better, I can recommend it, but IMHO the best > candidate for this is the testing patch #4 from this thread, which > alas wasn't even tested... So, Chris, if you could give it a try in > the meantime (without any other patches)? > > Thanks, > Jarek P. > > (resend testing patch #4 - for 2.6.27 or 2.6.28) > --- > > diff -Nurp a2.6.27.7/net/sched/sch_htb.c b2.6.27.7/net/sched/sch_htb.c > --- a2.6.27.7/net/sched/sch_htb.c 2008-12-11 08:16:16.000000000 +0000 > +++ b2.6.27.7/net/sched/sch_htb.c 2008-12-15 10:44:32.000000000 +0000 > @@ -924,6 +924,7 @@ static struct sk_buff *htb_dequeue(struc > } > } > sch->qstats.overlimits++; > + qdisc_watchdog_cancel(&q->watchdog); > qdisc_watchdog_schedule(&q->watchdog, next_event); > fin: > return skb; I hope you can forgive me, but since I have something that works on a production machine, I am not in a position in which I can test this. Chris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/