Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765933AbZAOOu3 (ORCPT ); Thu, 15 Jan 2009 09:50:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759790AbZAOOuF (ORCPT ); Thu, 15 Jan 2009 09:50:05 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:45433 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759477AbZAOOuB (ORCPT ); Thu, 15 Jan 2009 09:50:01 -0500 Date: Thu, 15 Jan 2009 15:49:34 +0100 From: Ingo Molnar To: Sam Ravnborg Cc: Geert Uytterhoeven , Jaswinder Singh Rajput , Jaswinder Singh Rajput , Alan Cox , Andrew Morton , David Miller , x86 maintainers , LKML , netdev Subject: Re: [PULL -tip] fixed few make headers_check warnings Message-ID: <20090115144934.GA872@elte.hu> References: <1231836016.3212.41.camel@jaswinder.satnam> <3f9a31f40901140129i1389f47frf32808f3a695a118@mail.gmail.com> <20090114153825.GB32082@uranus.ravnborg.org> <3f9a31f40901140759s1542e6cclae1808b796c2b1a9@mail.gmail.com> <20090114201513.GC1556@uranus.ravnborg.org> <20090115111134.GB22850@elte.hu> <20090115143717.GA11991@uranus.ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090115143717.GA11991@uranus.ravnborg.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1579 Lines: 41 * Sam Ravnborg wrote: > On Thu, Jan 15, 2009 at 12:11:34PM +0100, Ingo Molnar wrote: > > > > * Sam Ravnborg wrote: > > > > > So when I see "capability.h: extern's make no sense in userspace" the > > > perfect approach would be that the whole file was checked. > > > > > > This is a much bigger task that just removing the warning. > > > > The problem is, you just littered the kernel with a ton of warnings and > > declared that fixing them is a 'much bigger task'. > > > > It's not good to start projects like this, because they simply never > > finish. It's _much_ better to first reach a zero baseline via minimal > > fixes, then enforce 'look at the whole thing' for all _NEW_ files and > > changes. > > > > That's how we are using checkpatch in the -tip topics, and it's working > > very nicely. > > > > Could we please start it like that? > > I would have done such have I had more time to do this stuff. Real life > just hit me after vacation finished and deadline approaching. > > I can disable the warnings around -rc7 if we think they are too noisy > when we release the next kernel. they are perfectly fine i think, lets just not do the full approach now and reach a zero baseline first. Then perfectionism can start again, at a much more manageable flux. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/