Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762969AbZAOSGV (ORCPT ); Thu, 15 Jan 2009 13:06:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756283AbZAOSGE (ORCPT ); Thu, 15 Jan 2009 13:06:04 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:56172 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752911AbZAOSGA (ORCPT ); Thu, 15 Jan 2009 13:06:00 -0500 Date: Thu, 15 Jan 2009 10:05:11 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Matthew Wilcox cc: Ingo Molnar , Peter Zijlstra , "Paul E. McKenney" , Gregory Haskins , Andi Kleen , Chris Mason , Andrew Morton , Linux Kernel Mailing List , linux-fsdevel , linux-btrfs , Thomas Gleixner , Nick Piggin , Peter Morreale , Sven Dietrich , Dmitry Adamushko , Johannes Weiner Subject: Re: [GIT PULL] adaptive spinning mutexes In-Reply-To: <20090115174440.GF29283@parisc-linux.org> Message-ID: References: <1231859742.442.128.camel@twins> <1231863710.7141.3.camel@twins> <1231864854.7141.8.camel@twins> <1231867314.7141.16.camel@twins> <1231952436.14825.28.camel@laptop> <20090114183319.GA18630@elte.hu> <20090114184746.GA21334@elte.hu> <20090114192811.GA19691@elte.hu> <20090115174440.GF29283@parisc-linux.org> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1530 Lines: 39 On Thu, 15 Jan 2009, Matthew Wilcox wrote: > > I asked a couple of our benchmarking teams to try -v9. Neither the OLTP > benchmark, nor the kernel-perf test suite found any significant > performance change. I suspect mutex contention isn't a significant > problem for most workloads. We've been very good about spreading out mutexes. The normal kernel really only does it for write accesses to the same directory, and readdir(). Almost everything else is totally in the noise. I think Ingo's benchmark essentially tests exactly that "write to same directory" case, and little else. Unless: > Has anyone found a non-synthetic benchmark where this makes a > significant difference? Aside from btrfs, I mean. Yea, if you have some particular filesystem (or other subsystem) that uses a global mutex, you'll obviously see way more contention. Btrfs may not be _unique_ in this regard, but it's definitely doing something that isn't good. Btw, it's doing something that ext3 also used to do iirc, until we fixed it to use spinlocks instead (the block group lock in particular). Yeah - just double-checked. Commit c12b9866ea52 in the historical Linux archive, from 2003. Which made block allocation protected by a per-group spinlock, rather than lock_super(). Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/