Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935573AbZAOXf7 (ORCPT ); Thu, 15 Jan 2009 18:35:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934342AbZAOXfb (ORCPT ); Thu, 15 Jan 2009 18:35:31 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:58138 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S935389AbZAOXf2 (ORCPT ); Thu, 15 Jan 2009 18:35:28 -0500 Date: Thu, 15 Jan 2009 15:35:29 -0800 (PST) Message-Id: <20090115.153529.134674284.davem@davemloft.net> To: w@1wt.eu Cc: herbert@gondor.apana.org.au, jarkao2@gmail.com, zbr@ioremap.net, dada1@cosmosbay.com, ben@zeus.com, mingo@elte.hu, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jens.axboe@oracle.com Subject: Re: [PATCH] tcp: splice as many packets as possible at once From: David Miller In-Reply-To: <20090115233220.GD1123@1wt.eu> References: <20090115230331.GB1123@1wt.eu> <20090115231934.GA8328@gondor.apana.org.au> <20090115233220.GD1123@1wt.eu> X-Mailer: Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 628 Lines: 15 From: Willy Tarreau Date: Fri, 16 Jan 2009 00:32:20 +0100 > Good catch Herbert, it's working fine now. The performance I get > (30.6 MB/s) is between the original splice version (24.1) and the > recently optimized one (35.7). That's not that bad considering > we're copying the data. Willy, see how much my skb clone removal in the patch I just posted helps, if at all. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/