Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758122AbZAPGuh (ORCPT ); Fri, 16 Jan 2009 01:50:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753044AbZAPGuW (ORCPT ); Fri, 16 Jan 2009 01:50:22 -0500 Received: from brick.kernel.dk ([93.163.65.50]:22189 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753550AbZAPGuV (ORCPT ); Fri, 16 Jan 2009 01:50:21 -0500 Date: Fri, 16 Jan 2009 07:48:58 +0100 From: Jens Axboe To: Dongjun Shin Cc: James Bottomley , Hugh Dickins , Grant Grundler , Greg Freemyer , Tejun Heo , Michael Tokarev , Kay Sievers , Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Alan Cox Subject: Re: [PATCH] block: export SSD/non-rotational queue flag through sysfs Message-ID: <20090116064857.GT30821@kernel.dk> References: <496ECBA0.60209@gmail.com> <87f94c370901150707h10506e99reaa40c23e32ab18c@mail.gmail.com> <1232035561.5966.48.camel@localhost.localdomain> <1232046039.5966.54.camel@localhost.localdomain> <1232061429.5966.87.camel@localhost.localdomain> <1232066174.5966.92.camel@localhost.localdomain> <7fe698080901151952u4c6157d3tca8d745b69cacc1e@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7fe698080901151952u4c6157d3tca8d745b69cacc1e@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2485 Lines: 54 On Fri, Jan 16 2009, Dongjun Shin wrote: > On Fri, Jan 16, 2009 at 9:36 AM, James Bottomley > wrote: > > > > On Thu, 2009-01-15 at 23:50 +0000, Hugh Dickins wrote: > > > On Thu, 15 Jan 2009, James Bottomley wrote: > > > > > > > > OK, so they could be calculated on the fly in the elevators, I suppose. > > > > But what would the value be? Right now we use the nonrotational flag to > > > > basically not bother with plugging (no point if no seek penalty) on > > > > certain events where we'd previously have waited for other I/O to join. > > > > But that's really a seek penalty parameter rather than the idea of read > > > > or write costing (although the elevators usually track these dynamically > > > > anyway ... as part of the latency calculations but not explicitly). > > > > > > ... not bother with plugging (no point if no seek penalty) ... > > > > > > I thought there was considerable advantage to plugging writes > > > (in case they turn out to be adjacent) on current and older > > > generations of non-rotational storage? > > > > Heh, you get as many answers to that one as their are SSD manufacturers. > > However, the consensus seems to be that all MLC and SLC flash has a RAID > > like architecture internally, thus it can actually be *faster* if you > > send multiple commands (each area of the RAID processes independently). > > Of course, you have to be *able* to send multiple commands, so the > > device must implement TCQ/NCQ, but if it does, it's actually beneficial > > *not* to wait even if the requests are adjacent. > > > > However, the reason the nonrotational flag is set from user space is > > precisely so if we do find an SSD that has this property, we can just > > not set the nonrotational queue flag. > > > > Not all non-rotational SSDs are created equal (as Intel said). > > Some SSD performs better as the I/O queue length increase, while others not. > For SSD with scalable queueing performance, it might be better to allow > multiple discrete I/Os. > > I'm not sure if "non-rotational" is well suited for tuning the > behavior of elevator merging. It's not tuning merging, that's a seperate tuning knob if someone wishes to turn that off. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/