From: Arnd Bergmann <arnd@arndb.de>
To: Pavel Machek <pavel@suse.cz>
Subject: Re: nbd: add locking to nbd_ioctl
Date: Fri, 16 Jan 2009 13:29:08 +0100
User-Agent: KMail/1.9.9
Cc: kernel list <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@osdl.org>,
       Paul.Clements@steeleye.com
References: <20090116115512.GA10771@elf.ucw.cz>
In-Reply-To: <20090116115512.GA10771@elf.ucw.cz>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200901161329.08588.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 700
Lines: 15

On Friday 16 January 2009, Pavel Machek wrote:
> The code was written with "oh big kernel lock, please protect me from
> all the evil" mentality: it does not locks its own data structures, it
> just hopes that big kernel lock somehow helps.

If the locking is ok now, can you also move the call to ->ioctl()? instead
of locked_ioctl()? That would also be a good opportunity to move to
compat_ioctl() and kill the handlers in fs/compat_ioctl.c.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/