From: Arnd Bergmann <arnd@arndb.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH 3/5] Add preadv and pwritev system calls.
Date: Fri, 16 Jan 2009 18:34:01 +0100
User-Agent: KMail/1.9.9
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
       linux-api@vger.kernel.org, aarcange@redhat.com
References: <1232124344-25892-1-git-send-email-kraxel@redhat.com> <1232124344-25892-4-git-send-email-kraxel@redhat.com>
In-Reply-To: <1232124344-25892-4-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Message-Id: <200901161834.02481.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1771
Lines: 33

On Friday 16 January 2009, Gerd Hoffmann wrote:
> +asmlinkage ssize_t compat_sys_preadv(unsigned long fd,
> +???????????????const struct compat_iovec __user *vec,
> +???????????????unsigned long vlen, u32 pos_high, u32 pos_low);
> +asmlinkage ssize_t compat_sys_pwritev(unsigned long fd,
> +???????????????const struct compat_iovec __user *vec,
> +???????????????unsigned long vlen, u32 pos_high, u32 pos_low);
> ?
> ?int compat_do_execve(char * filename, compat_uptr_t __user *argv,
> ???????? ? ? ? ?compat_uptr_t __user *envp, struct pt_regs * regs);
> diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
> index 16875f8..333377e 100644
> --- a/include/linux/syscalls.h
> +++ b/include/linux/syscalls.h
> @@ -456,6 +456,10 @@ asmlinkage long sys_pread64(unsigned int fd, char __user *buf,
> ???????????????????????? ? ?size_t count, loff_t pos);
> ?asmlinkage long sys_pwrite64(unsigned int fd, const char __user *buf,
> ???????????????????????? ? ? size_t count, loff_t pos);
> +asmlinkage long sys_preadv(unsigned long fd, const struct iovec __user *vec,
> + ? ? ? ? ? ? ? ? ? ? ? ? ? unsigned long vlen, u32 pos_high, u32 pos_low);
> +asmlinkage long sys_pwritev(unsigned long fd, const struct iovec __user *vec,
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ?unsigned long vlen, u32 pos_high, u32 pos_low);

Conventionally, the 'fd' argument has type 'int', not 'unsigned long', but you
evidently copied this from readv/writev, so you can't really be blamed for it.
Not sure what the right thing to do here is.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/