Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937185AbZAPSt7 (ORCPT ); Fri, 16 Jan 2009 13:49:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S937090AbZAPSt0 (ORCPT ); Fri, 16 Jan 2009 13:49:26 -0500 Received: from smtp-out.google.com ([216.239.45.13]:45960 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937078AbZAPStY (ORCPT ); Fri, 16 Jan 2009 13:49:24 -0500 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=mime-version:in-reply-to:references:date:message-id:subject:from:to: cc:content-type:content-transfer-encoding: x-gmailtapped-by:x-gmailtapped; b=mCyxPntZNXFlBddeaX238wn0R27znNaXFFYSrdNud3Ja9RciTvFYhfdlLHcxkFt5m rtoHRVMYmByM/SKGKeKdg== MIME-Version: 1.0 In-Reply-To: <20090116093101.6d77b69b.akpm@linux-foundation.org> References: <20090116152721.GA6994@havoc.gtf.org> <20090116093101.6d77b69b.akpm@linux-foundation.org> Date: Fri, 16 Jan 2009 10:49:19 -0800 Message-ID: Subject: Re: [git patches] libata fixes From: Grant Grundler To: Andrew Morton Cc: Jeff Garzik , Linus Torvalds , linux-ide@vger.kernel.org, LKML Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-GMailtapped-By: 172.28.16.144 X-GMailtapped: grundler Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 753 Lines: 23 On Fri, Jan 16, 2009 at 9:31 AM, Andrew Morton wrote: ... >> +static void octeon_cf_tf_read16(struct ata_port *ap, struct ata_taskfile *tf) >> +{ >> + u16 blob; >> + /* The base of the registers is at ioaddr.data_addr. */ >> + void __iomem *base = ap->ioaddr.data_addr; >> + >> + blob = __raw_readw(base + 0xc); > > why __raw? Avoid byte swapping. If it's "native" HW on Big Endian platform, byte swapping isn't needed. If it's working, it's correct. hth, grant -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/