Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936428AbZAPTCb (ORCPT ); Fri, 16 Jan 2009 14:02:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756481AbZAPTCT (ORCPT ); Fri, 16 Jan 2009 14:02:19 -0500 Received: from smtp-out.google.com ([216.239.33.17]:50157 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756172AbZAPTCS (ORCPT ); Fri, 16 Jan 2009 14:02:18 -0500 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=mime-version:in-reply-to:references:date:message-id:subject:from:to: cc:content-type:content-transfer-encoding: x-gmailtapped-by:x-gmailtapped; b=MFZzvkD2WFBfxg8gTGy42+p3nfcoLXjnSAjTHqeq0eRtJ0mSZa+P3MjutZLErdk+z CYBCWYxuhrK0D4i5jtvSg== MIME-Version: 1.0 In-Reply-To: <20090116090928.e43c986e.akpm@linux-foundation.org> References: <1232117771.3224.21.camel@localhost.localdomain> <20090116090928.e43c986e.akpm@linux-foundation.org> Date: Fri, 16 Jan 2009 11:02:12 -0800 Message-ID: Subject: Re: [GIT PATCH] firs round of SCSI bug fixes for 2.6.29-rc1 From: Grant Grundler To: Andrew Morton Cc: James Bottomley , Linus Torvalds , linux-scsi , linux-kernel Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-GMailtapped-By: 172.28.16.148 X-GMailtapped: grundler Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 999 Lines: 26 On Fri, Jan 16, 2009 at 9:09 AM, Andrew Morton wrote: ... >> + CHIPREG_WRITE32(&ioc->chip->Doorbell, 0xC0FFEE00); >> + panic("%s: Firmware is halted due to command timeout\n", >> + ioc->name); >> + } >> +} >> +EXPORT_SYMBOL(mpt_halt_firmware); > > Doing a panic() after we've already detected an error is plain nasty. > Is there no way in which we can allow the kernel to continue? Basically what James said. It's not long though: only 6 emails. I started that thread thinking the same thing you did: http://marc.info/?t=123123569200003&r=1&w=2 TBH, I still wouldn't implement it the way LSI maintainers did. I'm happy they are the maintainers and it's their call. grant -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/