Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937202AbZAPTOj (ORCPT ); Fri, 16 Jan 2009 14:14:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S937135AbZAPTMb (ORCPT ); Fri, 16 Jan 2009 14:12:31 -0500 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:36249 "EHLO gprs189-60.eurotel.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937024AbZAPTM2 (ORCPT ); Fri, 16 Jan 2009 14:12:28 -0500 Date: Thu, 15 Jan 2009 08:40:44 +0100 From: Pavel Machek To: Samuel Thibault , Alan Cox , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, dmitry.torokhov@gmail.com, linux-input@vger.kernel.org Subject: Re: Re (hello?): [PATCH] Let keyboard notifiers modify key codes Message-ID: <20090115074044.GA1599@ucw.cz> References: <20090107005813.GA4987@const.famille.thibault.fr> <20090109212358.GG5073@const.famille.thibault.fr> <20090109213555.7f9275c9@lxorguk.ukuu.org.uk> <20090109214357.GH5073@const.famille.thibault.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20090109214357.GH5073@const.famille.thibault.fr> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1577 Lines: 35 On Fri 2009-01-09 22:43:57, Samuel Thibault wrote: > Alan Cox, le Fri 09 Jan 2009 21:35:55 +0000, a ?crit : > > Samuel Thibault wrote: > > > > > Came somebody have a look at this? The need is real, the only question > > > that comes to my mind is whether notifiers are allowed to modify the > > > param they are given. Since they are not marked const, I'd guess it'd > > > be ok? > > > > The notifier code doesn't care. > > I know, but I'm asking about current practice. > > > > Make kbd_keycode() read param.value after calling the keyboard notification > > > chain, to let the callee change the translation on the fly. This for instance > > > permits to remap the physical positions of the keys independently of the > > > configured keymap, for e.g. single-handed people. > > > > Surely that is just a new keymap ? > > No. That would mean a lot of keymapSSS. Doing it the keymap way > would require to have us, us-revert-left, us-revert-right, en-uk, > uk-revert-left, uk-revert-right, etc. I really don't like that approach, > thus the "independently of the configured keymap". ...and that is ok if you autogenerate those keymaps, right? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/