Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937327AbZAPTVm (ORCPT ); Fri, 16 Jan 2009 14:21:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755281AbZAPTVZ (ORCPT ); Fri, 16 Jan 2009 14:21:25 -0500 Received: from nxgate.netxen.com ([38.99.60.130]:12798 "EHLO nxexch.unminc.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751308AbZAPTVY convert rfc822-to-8bit (ORCPT ); Fri, 16 Jan 2009 14:21:24 -0500 From: Dhananjay Phadke To: David Miller CC: "netdev@vger.kernel.org" , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "mingo@elte.hu" Date: Fri, 16 Jan 2009 11:21:24 -0800 Subject: RE: [PATCH 2/2] netxen: include ipv6.h (fixes build failure) Thread-Topic: [PATCH 2/2] netxen: include ipv6.h (fixes build failure) Thread-Index: Acl4DWHdKGg61jvDQGynmFR5SF/z2QAAbyUg Message-ID: <9FB481EF4C70734186A21A64437F637C02A100BB7F@nxexch.unminc.com> References: <1232130484-25188-1-git-send-email-dhananjay@netxen.com> <1232130484-25188-3-git-send-email-dhananjay@netxen.com> <20090116.110452.77631610.davem@davemloft.net> In-Reply-To: <20090116.110452.77631610.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="windows-1250" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1658 Lines: 47 My bad, I copy-pasted the --to --cc list to git command line and missed out the original Sender in that email. Double apologies to Ingo, first for introducing the build error and other for fixing without credit to reporter :-(. Thanks Ingo, Dave. -Dhananjay -----Original Message----- From: David Miller [mailto:davem@davemloft.net] Sent: Friday, January 16, 2009 11:05 To: Dhananjay Phadke Cc: netdev@vger.kernel.org; akpm@linux-foundation.org; linux-kernel@vger.kernel.org; mingo@elte.hu Subject: Re: [PATCH 2/2] netxen: include ipv6.h (fixes build failure) From: Dhananjay Phadke Date: Fri, 16 Jan 2009 10:28:04 -0800 > Fixes a build error in absence of CONFIG_IPV6: > > drivers/net/netxen/netxen_nic_main.c:1189: error: implicit declaration of function 'ipv6_hdr' > drivers/net/netxen/netxen_nic_main.c:1189: error: invalid type argument of '->' > > Signed-off-by: Dhananjay Phadke Gee, thanks for not even mentioning Ingo having reported this problem in your commit message. :-(( I've fixed this when committing. You didn't even CC: him on this patch posting, what gives? No virus found in this incoming message. Checked by AVG. Version: 7.5.526 / Virus Database: 270.10.6/1889 - Release Date: 1/12/2009 20:18 No virus found in this outgoing message. Checked by AVG. Version: 7.5.526 / Virus Database: 270.10.6/1889 - Release Date: 1/12/2009 20:18 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/