Date: Sat, 17 Jan 2009 17:20:37 +0000
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk,
       linux-omap@vger.kernel.org
Subject: Re: [PATCH 07/10] omap mailbox: add save_/restore_ctx() for PM
Message-ID: <20090117172037.GF12341@n2100.arm.linux.org.uk>
References: <20090116081919.17571.34378.stgit@oreo.research.nokia.com> <20090116082737.17571.53738.stgit@oreo.research.nokia.com> <20090117171044.GE12341@n2100.arm.linux.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20090117171044.GE12341@n2100.arm.linux.org.uk>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1863
Lines: 59

On Sat, Jan 17, 2009 at 05:10:44PM +0000, Russell King - ARM Linux wrote:
> On Fri, Jan 16, 2009 at 10:27:37AM +0200, Hiroshi DOYU wrote:
> > diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c
> > index a877305..544dde9 100644
> > --- a/arch/arm/mach-omap2/mailbox.c
> > +++ b/arch/arm/mach-omap2/mailbox.c
> > @@ -32,6 +32,8 @@
> >  #define MAILBOX_IRQ_NEWMSG(u)		(1 << (2 * (u)))
> >  #define MAILBOX_IRQ_NOTFULL(u)		(1 << (2 * (u) + 1))
> >  
> > +#define MBOX_REG_SIZE			0x120
> > +
> >  static void __iomem *mbox_base;
> >  
> >  struct omap_mbox2_fifo {
> > @@ -47,6 +49,7 @@ struct omap_mbox2_priv {
> >  	unsigned long irqstatus;
> >  	u32 newmsg_bit;
> >  	u32 notfull_bit;
> > +	char ctx[MBOX_REG_SIZE];
> 
> 	u32 ctx[MOX_REG_SIZE / sizeof(u32)];
> 
> ?
> 
> >  };
> >  
> >  static struct clk *mbox_ick_handle;
> > @@ -167,6 +170,36 @@ static int omap2_mbox_is_irq(struct omap_mbox *mbox,
> >  	return (enable & status & bit);
> >  }
> >  
> > +static void omap2_mbox_save_ctx(struct omap_mbox *mbox)
> > +{
> > +	int i;
> > +	struct omap_mbox2_priv *p = mbox->priv;
> > +
> > +	for (i = 0; i < MBOX_REG_SIZE; i += sizeof(u32)) {
> > +		u32 val;
> > +
> > +		val = mbox_read_reg(i);
> > +		*(u32 *)(p->ctx + i) = val;
> 
> 		p->ctx[i] = mbox_read_reg(i);

Hmm, don't forget 'i' is an offset not an index, so...

?define MBOX_NR_REGS (MBOX_REG_SIZE / sizeof(u32))

	for (i = 0; i < MBOX_NR_REGS; i++) {
		p->ctx[i] = mbox_read_reg(i * sizeof(u32));

(you'll have to excuse the '?' there - my keyboard currently does not have
a 'hash' key for some Fedora 9 post upgrade silly reason.)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/