Date: Sat, 17 Jan 2009 20:09:13 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Arnaldo Carvalho de Melo <acme@redhat.com>,
       Jens Axboe <jens.axboe@oracle.com>,
       Steven Rostedt <rostedt@goodmis.org>,
       Frederic Weisbecker <fweisbec@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] ftrace interface for blktrace
Message-ID: <20090117190913.GA17722@elte.hu>
References: <20090116181611.GE6562@ghostprotocols.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090116181611.GE6562@ghostprotocols.net>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 986
Lines: 28


* Arnaldo Carvalho de Melo <acme@redhat.com> wrote:

> Hi Jens,
> 
> 	The patch below adds a ftrace interface for blktrace, allowing 
> people to use it without any required userspace tools, using sysfs to 
> setup the act_mask, pid, start_lba, end_lba.

Very nice patch!

Jens, i'm wondering what's your take on this direction is. I think the 
consolidation effect is great and the built-in IO tracing capabilities are 
very nice.

We can still get the raw events too and do user-space post-processing, 
when that is desired - so this does not limit anything that blktrace was 
able to do before - it only extends on it.

Is there any particular blktrace feature you can think of that is not 
present in the blktrace ftrace plugin?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/