Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932295AbZAQWSW (ORCPT ); Sat, 17 Jan 2009 17:18:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760537AbZAQWRy (ORCPT ); Sat, 17 Jan 2009 17:17:54 -0500 Received: from pfepb.post.tele.dk ([195.41.46.236]:60228 "EHLO pfepb.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756705AbZAQWRx (ORCPT ); Sat, 17 Jan 2009 17:17:53 -0500 Date: Sat, 17 Jan 2009 23:19:32 +0100 From: Sam Ravnborg To: David Woodhouse Cc: Jaswinder Singh Rajput , Ingo Molnar , x86 maintainers , urs.thuermann@volkswagen.de, oliver.hartkopp@volkswagen.de, linux-media@vger.kernel.org, netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, bfields@fieldses.org, neilb@suse.de, linux-nfs@vger.kernel.org, linux-raid@vger.kernel.org, dbrownell@users.sourceforge.net, spi-devel-general@lists.sourceforge.net, netdev@vger.kernel.org, greg@kroah.com, linux-usb@vger.kernel.org, linux-mtd@lists.infradead.org, tiwai@suse.de, mchehab@infradead.org, LKML , Andrew Morton Subject: Re: [GIT PULL -tip] fix 33 make headers_check warnings Message-ID: <20090117221932.GA4956@uranus.ravnborg.org> References: <1232223441.3966.22.camel@localhost.localdomain> <1232228261.27094.0.camel@macbook.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1232228261.27094.0.camel@macbook.infradead.org> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 921 Lines: 29 On Sun, Jan 18, 2009 at 08:37:41AM +1100, David Woodhouse wrote: > On Sun, 2009-01-18 at 01:47 +0530, Jaswinder Singh Rajput wrote: > > --- a/include/linux/dvb/audio.h > > +++ b/include/linux/dvb/audio.h > > @@ -24,9 +24,8 @@ > > #ifndef _DVBAUDIO_H_ > > #define _DVBAUDIO_H_ > > > > -#ifdef __KERNEL__ > > #include > > -#else > > +#ifndef __KERNEL__ > > #include > > #endif > > > > That patch looks wrong, and unnecessary. It was fine before. Nope - include/linux/dvb/audio.h failed to include linux/types.h despite the fact that is uses __u32 etc. But why the _kernel_ should include a userspace header is much more questionable. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/