Date: Sun, 18 Jan 2009 09:36:37 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Tejun Heo <tj@kernel.org>
Cc: Brian Gerst <brgerst@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/17] x86-64: Convert irqstacks to per-cpu
Message-ID: <20090118083637.GA21940@elte.hu>
References: <73c1f2160901160610l57e31a64j56fe9544bd2fd309@mail.gmail.com> <1232115396-26367-1-git-send-email-brgerst@gmail.com> <1232115396-26367-2-git-send-email-brgerst@gmail.com> <1232115396-26367-3-git-send-email-brgerst@gmail.com> <4972B6D9.4080101@kernel.org> <73c1f2160901172105p8ba1aa4v708e746d5548a79d@mail.gmail.com> <4972B967.4010606@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4972B967.4010606@kernel.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1747
Lines: 46


* Tejun Heo <tj@kernel.org> wrote:

> Hello,
> 
> Brian Gerst wrote:
> >> Also, as pda field name, irqstackptr might be fine but wouldn't it be
> >> better to rename it to at least irq_stack_ptr as this change requires
> >> touching every users anyway?
> > 
> > I kept the same name unless it would conflict with something.  If you
> > want to rename it, it should be a separate patch.
> 
> Sure, that's an option too but it might as well be done when making 
> those percpu variables.  I don't really see why those two changes should 
> be separate.  There isn't any reason why they shouldn't be separate 
> either but if you're already mucking around every user...

yes, we should do the rename in this same patch as both patches have no 
impact on the actual kernel image. (sans source code line and string 
related deltas in the image.) Feel free to do the rename in his patch - 
that's the fastest way.

I'd suggest to rename from:

  DECLARE_PER_CPU(char, irqstack[IRQSTACKSIZE]);
  DECLARE_PER_CPU(char *, irqstackptr);

to:

  DECLARE_PER_CPU(char, irq_stack[IRQSTACKSIZE]);
  DECLARE_PER_CPU(char *, irq_stack_ptr);

In other cases, lets get Brian's patches in without further latencies so 
that we drain his pending-patches pipeline and get a consolidated base 
everyone can work from. Brian already had an unfortunate (and 
time-consuming) rebase/conflict-resolution pass due to us moving the 
percpu code from under him. We can do non-critical followups in separate 
delta patches.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/