Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934831AbZARRmb (ORCPT ); Sun, 18 Jan 2009 12:42:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934721AbZARRmK (ORCPT ); Sun, 18 Jan 2009 12:42:10 -0500 Received: from fg-out-1718.google.com ([72.14.220.154]:12268 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934707AbZARRmI (ORCPT ); Sun, 18 Jan 2009 12:42:08 -0500 Message-ID: <154e089b0901180942o46b80006q5e0d586cb3e1841c@mail.gmail.com> Date: Sun, 18 Jan 2009 18:42:06 +0100 From: "Hannes Eder" To: "Julia Lawall" , "Jaswinder Singh Rajput" Subject: Re: [PATCH 2/3] drivers/gpu/drm: fix sparse warnings: unexport symbols Cc: dri-devel@lists.sourceforge.net, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20090118152725.4179.40835.stgit@vmbox.hanneseder.net> <20090118152848.4179.85741.stgit@vmbox.hanneseder.net> <1232294164.24415.3.camel@localhost.localdomain> <154e089b0901180804k46e9411lcbc10f591871b14@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1182 Lines: 26 On Sun, Jan 18, 2009 at 5:11 PM, Julia Lawall wrote: > I don't know anything about this specific context, but aren't things in > general exported so that external modules can use them? If that is the > case, grepping over the kernel sources is not sufficient. Good point, but it indicates that the function does not have a caller within kernel tree. Ok, there could be other clients. So this patch might just be a hint for the original author or maintainer that there is maybe no need to export this function. On Sun, Jan 18, 2009 at 5:18 PM, Jaswinder Singh Rajput wrote: > If it is EXPORTED you cannot make it static. EXPORTED means it can be > used from a kernel module. Right, that's why I have made it static and removed the EXPORT_SYMBOL, all under the assumption that there is _no_ client for this function, but there may be some outside the kernel tree. I can not judge this. Hannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/