Subject: Re: [GIT PULL -tip v3] fix 39 'make headers_check' warnings
From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Ingo Molnar <mingo@elte.hu>, Andrew Morton <akpm@linux-foundation.org>,
       x86 maintainers <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
In-Reply-To: <20090118190836.GA2294@uranus.ravnborg.org>
References: <1232287474.3130.19.camel@localhost.localdomain>
	 <20090118172800.GB22624@elte.hu> <20090118185034.GA26908@elte.hu>
	 <20090118190836.GA2294@uranus.ravnborg.org>
Content-Type: text/plain
Date: Mon, 19 Jan 2009 07:46:05 +0530
Message-Id: <1232331365.3129.7.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1036
Lines: 33

On Sun, 2009-01-18 at 20:08 +0100, Sam Ravnborg wrote:
> > 
> > diff --git a/arch/x86/include/asm/swab.h b/arch/x86/include/asm/swab.h
> > index 306d417..613be68 100644
> > --- a/arch/x86/include/asm/swab.h
> > +++ b/arch/x86/include/asm/swab.h
> > @@ -1,12 +1,15 @@
> >  #ifndef _ASM_X86_SWAB_H
> >  #define _ASM_X86_SWAB_H
> >  
> > -#include <asm/types.h>
> > +#include <linux/types.h>
> > +#ifdef __KERNEL__
> >  #include <linux/compiler.h>
> > +#endif /* __KERNEL__ */
> 
> compiler.h includes should be nuked by make headers_instll automatically.
> 

But the problem is compiler.h provide extra line space in userspace
header files because of nuking them.

So I moved compiler.h in __KERNEL__ as extra cleanup, it is not harmful
but looks much nicer in userspace header files

--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/