DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=subject:from:to:cc:in-reply-to:references:content-type:date
         :message-id:mime-version:x-mailer:content-transfer-encoding;
        b=ZOx1pBZ7Py4fOZpsxOis+WGd1wS3d67gK52YeSn3rTJqao9gChPhYeVmSSHt8qxWVv
         Zdun5e7Ry+T6Q5KxrrxkOxAofkdrvpPhzK3ETiTSKaX2CDAK4KRH6sCd3kaDRJ/fatwN
         ACmkdxXuQAHj1WOOX+r3PXgbtqQQLh8zYTlu4=
Subject: Re: [GIT PULL -tip v3] fix 39 'make headers_check' warnings
From: Harvey Harrison <harvey.harrison@gmail.com>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Andrew Morton <akpm@linux-foundation.org>,
       Sam Ravnborg <sam@ravnborg.org>, x86 maintainers <x86@kernel.org>,
       LKML <linux-kernel@vger.kernel.org>
In-Reply-To: <1232331011.3129.4.camel@localhost.localdomain>
References: <1232287474.3130.19.camel@localhost.localdomain>
	 <20090118172800.GB22624@elte.hu>  <20090118185034.GA26908@elte.hu>
	 <1232331011.3129.4.camel@localhost.localdomain>
Content-Type: text/plain
Date: Sun, 18 Jan 2009 18:20:46 -0800
Message-Id: <1232331646.5570.5.camel@brick>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 996
Lines: 28

On Mon, 2009-01-19 at 07:40 +0530, Jaswinder Singh Rajput wrote:
> On Sun, 2009-01-18 at 19:50 +0100, Ingo Molnar wrote:
> >  
> > why does such a change introduce new code? It is duplicating existing code 
> > instead of cleaning it all up.
> > 
> 
> That's why I was requesting you to check asm/swab.h because I was in
> doubt whether we need these functions in userspace or not.
> 
> If we do not need these functions in userspace then I will clean these
> up.
> 

As part of doing the swab.h splitout it was very tempting to just stop
exporting _all_ of the asm/swab.h files now that there is a linux/swab.h.
But I ended up leaving things as they were on arches that did expose
their arch specific versions to userspace.

Just a thought.

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/