Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755584AbZASHc5 (ORCPT ); Mon, 19 Jan 2009 02:32:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752366AbZASHco (ORCPT ); Mon, 19 Jan 2009 02:32:44 -0500 Received: from ug-out-1314.google.com ([66.249.92.170]:23764 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbZASHcn (ORCPT ); Mon, 19 Jan 2009 02:32:43 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=eThwCBvIIC5d6uuzzXs/v0gERFUxu9twaX2kfG/SuK8vek3R7r0MPgQ33a11VSMw4w FUDFcJ2EDDJozSpiqNk6LWw/QLZUw7SHZLx8O+n3Yk9yDUir9ba3+5FXmVzL8RmogLcM zd4LH6ngkqOMM1OKgKHsYs2xdVKktgYuxn4aQ= Date: Mon, 19 Jan 2009 07:32:35 +0000 From: Jarek Poplawski To: Herbert Xu Cc: "David S. Miller" , Jens Axboe , Willy Tarreau , Changli Gao , Evgeniy Polyakov , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: Data corruption issue with splice() on 2.6.27.10 Message-ID: <20090119073235.GA4600@ff.dom.local> References: <20090106100112.GB9513@ff.dom.local> <20090106155715.GA28783@1wt.eu> <20090107093915.GA6899@ff.dom.local> <20090107122205.GA6051@1wt.eu> <20090107123153.GA9597@ff.dom.local> <20090107123504.GN32491@kernel.dk> <20090107124946.GA9677@ff.dom.local> <20090107125217.GA26235@gondor.apana.org.au> <20090112120257.GA5697@gondor.apana.org.au> <20090112131517.GD5901@ff.dom.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090112131517.GD5901@ff.dom.local> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 897 Lines: 22 On Mon, Jan 12, 2009 at 01:15:17PM +0000, Jarek Poplawski wrote: ... > I've wondered if something like this could work as a temporary hack? ... > @@ -776,7 +777,8 @@ ssize_t tcp_sendpage(struct socket *sock, struct page *page, int offset, > struct sock *sk = sock->sk; > > if (!(sk->sk_route_caps & NETIF_F_SG) || > - !(sk->sk_route_caps & NETIF_F_ALL_CSUM)) > + !(sk->sk_route_caps & NETIF_F_ALL_CSUM) || > + PageSlab(page)) > return sock_no_sendpage(sock, page, offset, size, flags); Just for the record: this wouldn't work yet:-( It should be probably something like "PageCompound(compound_head(page))" test instead. Jarek P. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/