Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Sat, 16 Feb 2002 03:07:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Sat, 16 Feb 2002 03:07:24 -0500 Received: from mail.pha.ha-vel.cz ([195.39.72.3]:19974 "HELO mail.pha.ha-vel.cz") by vger.kernel.org with SMTP id ; Sat, 16 Feb 2002 03:07:18 -0500 Date: Sat, 16 Feb 2002 09:07:15 +0100 From: Vojtech Pavlik To: Andre Hedrick Cc: Pavel Machek , Rob Landley , kernel list Subject: Re: small IDE cleanup: void * should not be used unless neccessary Message-ID: <20020216090715.A8948@suse.cz> In-Reply-To: <20020213225047.GI1454@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from andre@linuxdiskcert.org on Fri, Feb 15, 2002 at 05:08:20PM -0800 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 15, 2002 at 05:08:20PM -0800, Andre Hedrick wrote: > > > I know they're functionally equivalent, but so was the original void > > > *. :) > > > > Well, void * hides real errors. > > > > > Just an "as long as you're touching this line anyway, why leave the old > > > comment?" thing. A minor, in-passing nit at best... > > > > ide_hwgroup_t is used in 90% of rest of code, so I thought I better > > leave it there. > > So what do we do with the other 10% break it? Sheesh :-/ The other 10% won't break by the change, of course. -- Vojtech Pavlik SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/